Closed Bug 1433941 Opened 5 years ago Closed 3 years ago
Pass-through unrecognized arguments to pytest
47 bytes, text/x-phabricator-request
|Details | Review|
For debugging purposes it would be good to have support for --no-capture in `mach python-test`. Right now this option doesn't seem to be supported.
How may i proceed to solve this issue ?
Hi Kamit! You can find the pytest options here: https://dxr.mozilla.org/mozilla-central/source/config/mozunit.py#229 And you would have to add the capture option like here: https://searchfox.org/mozilla-central/source/testing/web-platform/tests/tools/wptrunner/wptrunner/executors/pytestrunner/runner.py#54-61 Andrew, would it make sense to also take the other options as used by wdspec tests?
So to clarify, we're just adding the ability to specify this on the command line right? Not making it the default. I was thinking we could use argparse.REMAINDER to get all unrecognized args in |mach python-test| (defined in python/mach_commands.py), then just forward those on to the test subprocess and have the subprocess append them to the pytest args.
Summary: Add --no-capture pass-through for pytests → Pass-through unrecognized arguments to pytest
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/9bfffecb5b80 Passed remainder arguments as it is |mach python-test| r=ahal
Assignee: nobody → anmol.agarwal001
You need to log in before you can comment on or make changes to this bug.