Closed
Bug 1433941
Opened 6 years ago
Closed 4 years ago
Pass-through unrecognized arguments to pytest
Categories
(Testing :: Python Test, enhancement)
Tracking
(firefox71 fixed)
RESOLVED
FIXED
mozilla71
Tracking | Status | |
---|---|---|
firefox71 | --- | fixed |
People
(Reporter: whimboo, Assigned: anmol.agarwal001)
Details
Attachments
(1 file)
For debugging purposes it would be good to have support for --no-capture in `mach python-test`. Right now this option doesn't seem to be supported.
Comment 1•6 years ago
|
||
How may i proceed to solve this issue ?
Reporter | ||
Comment 2•6 years ago
|
||
Hi Kamit! You can find the pytest options here: https://dxr.mozilla.org/mozilla-central/source/config/mozunit.py#229 And you would have to add the capture option like here: https://searchfox.org/mozilla-central/source/testing/web-platform/tests/tools/wptrunner/wptrunner/executors/pytestrunner/runner.py#54-61 Andrew, would it make sense to also take the other options as used by wdspec tests?
Flags: needinfo?(ahalberstadt)
Comment 3•6 years ago
|
||
So to clarify, we're just adding the ability to specify this on the command line right? Not making it the default. I was thinking we could use argparse.REMAINDER to get all unrecognized args in |mach python-test| (defined in python/mach_commands.py), then just forward those on to the test subprocess and have the subprocess append them to the pytest args.
Flags: needinfo?(ahalberstadt)
Updated•4 years ago
|
Summary: Add --no-capture pass-through for pytests → Pass-through unrecognized arguments to pytest
Assignee | ||
Comment 4•4 years ago
|
||
Pushed by ahalberstadt@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9bfffecb5b80 Passed remainder arguments as it is |mach python-test| r=ahal
Comment 6•4 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox71:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
Updated•4 years ago
|
Assignee: nobody → anmol.agarwal001
You need to log in
before you can comment on or make changes to this bug.
Description
•