1433947 - Enable Unit Tests for Firefox and FirefoxBeta schemas

Status: RESOLVED FIXED

(Firefox for iOS :: Build & Test, enhancement)

Description

[Isabel Rios[:isabel_rios]]

Unit Tests are running on master only on Fennec_Enterprise.

So when a release branch is created, and PRs run on Firefox and FirefoxBeta no tests run there.

Comment 1

[Isabel Rios[:isabel_rios]]

Attachment: Pull Request

As we commented, with this PR the unit tests that run on v10.x are enabled for master too for the same schemas so that when a release branch is created it will have the unit tests running on Firefox and FirefoxBeta schemas

Comment 2

[No-Jun Park [:njpark]]

Comment on attachment 8946275 [details] [review]
Pull Request

Noticed Stefan was listed in the Github reviewer list, but not here.  Should he be added as well?

Comment 3

[Isabel Rios[:isabel_rios]]

Since he mentioned about creating the PR on slack I added him to review so he knew it was done and also to check if he was fine with the tests enabled and having them enabled in master, not only on v11.x. I guess that is fine since those tests do not run unless the corresponding schemas are selected.

Lets ask him just in case to be sure he is fine with this PR too.

So Stefan, ni you ^^ Thanks!

Comment 4

[Isabel Rios[:isabel_rios]]

Merged master: https://github.com/mozilla-mobile/firefox-ios/commit/e2153c31fcd32779f6b4b724382038e97dd2b4cb

Comment 5

[Isabel Rios[:isabel_rios]]

Uplifted v11.x https://github.com/mozilla-mobile/firefox-ios/commit/0f87b86c2418694319e1311f247a34cae7bb7f81

Comment 6

[Isabel Rios[:isabel_rios]]

Bug closed, no need for ni? anymore