Clean up MOZ_UNUSED_ATTRIBUTE in Assertions.h

RESOLVED FIXED in Firefox 60

Status

()

enhancement
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: tjr, Assigned: tjr)

Tracking

Trunk
mozilla60
Points:
---

Firefox Tracking Flags

(firefox60 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
In Bug 1393538 I mucked around in Assertions.h and :dmajor pointed out several dumb things I did.  I should fix them.
Comment hidden (mozreview-request)

Comment 3

a year ago
I would like to work on this bug. Can you assign this bug to me?

Comment 4

a year ago
mozreview-review
Comment on attachment 8946445 [details]
Bug 1433971 Clean up Assertions.h with respect to Unused Attributes

https://reviewboard.mozilla.org/r/216384/#review222352

r=me, but I think the patch is missing something, see below.

::: commit-message-c0f08:10
(Diff revision 1)
> +Undo that wrong thing: restore MOZ_STATIC_ASSERT_UNUSED_ATTRIBUTE to the correct
> +place, have toolkit use the correct macro, and remove MOZ_UNUSED_ATTRIBUTE.

Where is the removal of `MOZ_UNUSED_ATTRIBUTE`?  Is it in a different patch?
Attachment #8946445 - Flags: review?(nfroyd) → review+
Comment hidden (mozreview-request)
(Assignee)

Comment 6

a year ago
(In reply to dvabhinav31@gmail.com from comment #3)
> I would like to work on this bug. Can you assign this bug to me?

I think I've got this one all set, just need to make sure it builds; but thanks for the interest! Bug 1430356 and Bug 1430356 would be similar types of issues maybe you'd be interested in.


(In reply to Nathan Froyd [:froydnj] from comment #4)
> Where is the removal of `MOZ_UNUSED_ATTRIBUTE`?  Is it in a different patch?

Woops. I forgot to do that. Updated patch, and I'll do another try run to make sure everything compiles fine.
(Assignee)

Comment 7

a year ago
(In reply to Tom Ritter [:tjr] from comment #6)
> (In reply to dvabhinav31@gmail.com from comment #3)
> > I would like to work on this bug. Can you assign this bug to me?
> 
> I think I've got this one all set, just need to make sure it builds; but
> thanks for the interest! Bug 1430356 and Bug 1430356 would be similar types
> of issues maybe you'd be interested in.


Sorry I meant Bug 1430355 and Bug 1430356

Comment 9

a year ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/fe06b53fc150
Clean up Assertions.h with respect to Unused Attributes r=froydnj
Keywords: checkin-needed

Comment 10

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/fe06b53fc150
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.