Here's the message I sent to David for this issue: Start the editor. Click on the HR in the default test document, then click on the HR toolbar button. Notice the dialog is OK, but I have commented out the popup after the "Width" editbox that selects Pixels vs. Percent. Now edit editor/ui/dialogs/content/EdHLineProps.xul. Look for this fragment: <!-- EXPOSE THIS TO SHOW POPUP MENU IN A DIALOG <xul:menu> <xul:titledbutton class="popup" id="pixelOrPercentButton" align="right" value="&percentPopup.value;"/> <xul:menupopup id="PixelOrPercentMenu"> <xul:menuitem value="&pixelsPopup.value;" oncommand="SetPixelOrPercentByID('pixelOrPercentButton', '')"/> <xul:menuitem value="&percentPopup.value;" oncommand="SetPixelOrPercentByID('pixelOrPercentButton', '%')"/> </xul:menupopup> </xul:menu> --> First off, does this look OK to you? To run this, delete the comment lines and do a "nmake -f makefile.win install" in the editor/ui directory again. Now repeat launching the editor and the HLine props dialog. If you click on the popup button labeled "percent", nothing happens, but even more weird, notice that the presence of the menu popup makes the OK and Cancel buttons (loaded from an overlay) disappear!
Charlie, could you (or QA) try a few things before we have Dave put his aching hands on this bug?: 1) Try another platform, like Mac, and see if it works there. 2) Try putting them in a non-modal dialog (assuming this one is modal). 3) Try putting a combo box in the same dialog. (if this doesn't work, reassign this bug to kmcclusk and cc rods) Thanks!
Well I certainly understand trying not to burden David any more. I actually got one to popup today, but clicking on the menu item didn't execute the associated command. I will continue investigating tomorow, although I still get the bizarre side effect of the disappearing OK/Cancel buttons. Why would non-modal dialogs have anything to do with this? (Doesn't seem like a realistic option anyway.) I would like to avoid switching to comboboxes (they are "butt ugly!) but we will if we have to.
My hands have deteriorated to the point where I can no longer type. I need help. If you think you can fix this bug on your own, please take it away from me. If you'd like to volunteer to be my hands for a specific bug, then I'll be happy to come up to your cube and sit with you and fix the bug (assuming you have the patience for that).
Status: NEW → RESOLVED
Last Resolved: 19 years ago
Resolution: --- → FIXED
QA Assigning to self for verification.
Summary: Popup menus dont' work in dialogs. → Popup menus don't work in dialogs.
Hey, Charles --- I'd like to verify this, but I'm not quite sure how. The existing pixels/% of window pop-up menu in the Horizontal Line Property looks identical to all of the other pop-up menus. The pop-up menu widget doesn't actually *work*, but that's a global problem. Would this bug then be considered fixed, or is there more to it? Thanks!
[e-mailed cmanske to ensure he saw the question.]
Didn't hear back from cmanske note (assuming he's out of town), so hunted down hyatt. Since the pop-up menu looks fine in this dialog on builds for the past two weeks or so, verifying as fixed.
[Oh --- builds checked were 11.22.99 AM builds on Win32, Mac OS & Linux.]
Sorry, I was out of town last week. Note that editor dialogs do NOT use the "popup menu", but rather a HTML SELECT widget, so they don't verify if popup menus work. But we do know that they work from other examples.
You need to log in before you can comment on or make changes to this bug.