Closed Bug 1434054 Opened 4 years ago Closed 4 years ago

Remove unused MacroAssembler functionality

Categories

(Core :: JavaScript Engine: JIT, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: lth, Assigned: lth)

References

Details

(Keywords: good-first-bug)

Attachments

(1 file)

At least these, which I stumbled over accidentally, are unused on all platforms:

repatchFarJump()
nopPatchableToNearJump()
patchNopToNearJump()
patchNearJumpToNop()
Hi,
I would like to work on this can you assign it to me?
Assignee: nobody → manikishanghantasala
Keywords: good-first-bug
Hi,
Can I know what should I do?
Do I remove the calls of the functions listed above?
You need to remove definitions and declarations of those functions on all platforms, and there should be no calls anywhere because these functions are supposed to be unused.
Thank you I will do it.
Stealing.
Assignee: manikishanghantasala → lhansen
Status: NEW → ASSIGNED
Attachment #8958403 - Flags: review?(bbouvier)
Comment on attachment 8958403 [details] [diff] [review]
bug1434054-remove-unused-masm.patch

Review of attachment 8958403 [details] [diff] [review]:
-----------------------------------------------------------------

Me gusta! Thanks.
Attachment #8958403 - Flags: review?(bbouvier) → review+
Pushed by lhansen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e96ef96eb6a3
Remove unused macroassembler functions.  r=bbouvier
https://hg.mozilla.org/mozilla-central/rev/e96ef96eb6a3
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.