1434126 - Web Apps keep running after they are killed

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Web Apps (PWAs), defect)

Description

[Jovan Gerodetti]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:59.0) Gecko/20100101 Firefox/59.0
Build ID: 20180125163041

Steps to reproduce:

1. add web.telegram.org to your home screen
2. start the application from your home screen
3. check the console to verify it logs this line "[SW] on message [object Object]"
4. remove the activity from the android activity manger


Actual results:

1. check the console again
2. it continues to log "[SW] on message [object Object]"


Expected results:

Killing the activity should kill the entire instance of the app. No java script should be executed anymore.

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

Dylan, can you take a look at this? IIRC we sometimes have a long delay for GeckoView.onDetachedFromWindow() to be called, which is the normal way things get cleaned up. We could just call GeckoSession.closeWindow() directly from WebAppActivity.onStop() to help things along, I think.

Comment 2

[Dylan Roeh (:droeh) (he/him)]

Attachment: Call GeckoSession.closeWindow from onDestroy()

It should be onDestroy rather than onStop, I'm pretty sure. Aside from that I changed closeWindow to log a warning if we try to double-close rather than throwing an exception so that we hopefully don't end up with any crashes if closeWindow somehow gets called on the same GeckoSession somewhere down the line.

Comment 3

[Dylan Roeh (:droeh) (he/him)]

Comment on attachment 8949017 [details] [diff] [review]
Call GeckoSession.closeWindow from onDestroy()

Forgot to flag for review.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fa7b76f98931
Call GeckoSession.closeWindow() from onDestroy() in CustomTabsActivity and WebAppActivity. r=snorp

Comment 5

[Noemi Erli[:noemi_erli]]

Backed out changeset fa7b76f98931 (bug 1434126) for Deleting file '.gradle.deps'bustages on a CLOSED TREE

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=fa7b76f98931251d2e54a02683f1503dbe0c1443&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=161118753&repo=mozilla-inbound

Backout push: https://hg.mozilla.org/integration/mozilla-inbound/rev/74a9633e67fa4b338c5185214d0289d1bc74df33

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ced7e4ed2a45
Call GeckoSession.closeWindow() from onDestroy() in CustomTabsActivity and WebAppActivity. r=snorp

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/ced7e4ed2a45