1434128 - Ignore comm-central sccache mozconfig when doing release sanity checks.

Status: RESOLVED FIXED

(Release Engineering :: Release Automation, defect)

Description

[Tom Prince [:tomprince]]

In Bug 1423801, configuration for using sccache for thunderbird builds was added, but it was deliberately not added to the release mozconfigs.

This should be an expected difference in the mozconfigs.

Comment 1

[Tom Prince [:tomprince]]

Attachment: Bug 1434128: Ignore comm-central's sccache mozconfig when comparing mozconfigs;

Review commit: https://reviewboard.mozilla.org/r/216418/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/216418/

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8946492 [details]
Bug 1434128: Ignore comm-central's sccache mozconfig when comparing mozconfigs;

https://reviewboard.mozilla.org/r/216418/#review222608

A couple of suggestions for improvements but I don't really mind now that this is Thunderbird only.

::: buildbot-helpers/mozconfig_whitelist:26
(Diff revision 1)
>  
>  for platform in ['linux', 'linux64']:
>      whitelist['nightly'][platform] += [
>          'ac_add_options --disable-elf-hack # --enable-elf-hack conflicts with --enable-profiling',
>          '. "$topsrcdir/build/mozconfig.cache"',
> +        '. "$commtopsrcdir/build/mozconfig.cache"',

Did you mean .../build/mozconfig.sccache here ?

::: buildbot-helpers/mozconfig_whitelist:35
(Diff revision 1)
>      whitelist['nightly'][platform] += [
>          'ac_add_options --enable-codesighs',
>          'mk_add_options MOZ_MAKE_FLAGS="-j4"',
>      ]
>  
>  for platform in ['linux', 'linux64', 'macosx64', 'win32', 'win64']:

Perhaps you can just add your new line in this loop, and not need it lots of places through the file.

Comment 3

[Tom Prince [:tomprince]]

https://hg.mozilla.org/build/tools/rev/88ec1d12dbd7b2041444236ea53270ae621d4f56