Closed
Bug 1434164
Opened 6 years ago
Closed 6 years ago
Support inlining policies.json file on test files
Categories
(Firefox :: Enterprise Policies, enhancement)
Tracking
()
RESOLVED
FIXED
Firefox 60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: Felipe, Assigned: Felipe)
Details
Attachments
(1 file)
A small suggestion made by Gijs, this should make the process of writing new tests a bit nicer, as it'll be no longer needed to create two separate files. I suggest we use this inlining for simple/small files, and keep using the separate file for larger ones.
| Comment hidden (mozreview-request) |
|
||
Comment 2•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8946539 [details] Bug 1434164 - Support inlining policies.json file on test files. https://reviewboard.mozilla.org/r/216558/#review222300 r=me - in the future we might want to look at just avoiding IO entirely, but I expect that's hard given the policy engine's setup?
Attachment #8946539 -
Flags: review?(gijskruitbosch+bugs) → review+
|
Assignee | |
Comment 3•6 years ago
|
||
(In reply to :Gijs from comment #2) > Comment on attachment 8946539 [details] > Bug 1434164 - Support inlining policies.json file on test files. > > https://reviewboard.mozilla.org/r/216558/#review222300 > > r=me - in the future we might want to look at just avoiding IO entirely, but > I expect that's hard given the policy engine's setup? Yeah. Honestly that hadn't occurred to me, but I feel that if I refactor stuff to avoid this IO, the tests wouldn't be testing the common path of reading the policies from a file. In any case, I'll keep it in mind for the future. Once things are proven to be working solid, I might end up doing that.
Pushed by felipc@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/2e5111f3d272 Support inlining policies.json file on test files. r=Gijs
Pushed by felipc@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/967967531194 Use ChromeUtils.defineModuleGetter. r=me ON A CLOSED TREE
|
||
Comment 6•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/2e5111f3d272 https://hg.mozilla.org/mozilla-central/rev/967967531194
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
You need to log in
before you can comment on or make changes to this bug.
Description
•