1434219 - Use marionette.port preference

Status: RESOLVED FIXED

(Testing :: Reftest, enhancement)

Description

[Andreas Tolfsen ❲:ato❳]

The reftest harness in layout/tools/reftest/runreftest.py uses the
marionette.defaultPrefs.port preference which has been deprecated
for some time (since Firefox 55).  We will want to change this to
maronette.port.

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1434219 - Use current Marionette prefs in reftest harness.

The marionette.defaultPrefs.port and marionette.logging preferences
have been deprecated for some time.  We want to move the reftest
harness to use marionette.port and marionette.log.level.

All officially recognised preferences are listed in
testing/marionette/prefs/marionette.js.

Review commit: https://reviewboard.mozilla.org/r/216620/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/216620/

Comment 2

[Geoff Brown [:gbrown]]

Comment on attachment 8946634 [details]
Bug 1434219 - Use current Marionette prefs in reftest harness.

https://reviewboard.mozilla.org/r/216620/#review222362

There is also a marionette.logging use at

https://dxr.mozilla.org/mozilla-central/rev/474d58c9137360c0fa1c85cdd11e3313b33b7cad/testing/mochitest/runtests.py#1833

Are you updating that in a separate bug?

Comment 3

[Andreas Tolfsen ❲:ato❳]

Ah, thanks!  I can do that in a separate bug since this is filed
in Testing :: Reftest.  Can I flag you for review there?

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/431161e00569
Use current Marionette prefs in reftest harness. r=gbrown

Comment 5

[Geoff Brown [:gbrown]]

(In reply to Andreas Tolfsen ‹:ato› from comment #3)
> Ah, thanks!  I can do that in a separate bug since this is filed
> in Testing :: Reftest.  Can I flag you for review there?

Yes, sounds good.

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/431161e00569