1434328 - process_util_linux.cc build error on Solaris due missing fork_delegate

Status: RESOLVED FIXED

(Firefox :: Untriaged, defect)

Description

[Petr Sumbera]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0
Build ID: 20180118215408

Steps to reproduce:

After fix for Bug 1401062:

https://hg.mozilla.org/mozilla-central/rev/400800683ab6

I see following error on Solaris:

gmake[1]: Entering directory '/scratch/firefox/obj-x86_64-pc-solaris2.11/ipc/chromium'
/usr/bin/g++ -std=gnu++14 -o process_util_linux.o -c -I/scratch/firefox/obj-x86_64-pc-solaris2.11/dist/stl_wrappers -I/scratch/firefox/obj-x86_64-pc-solaris2.11/dist/system_wrappers -include /scratch/firefox/config/gcc_hidden.h -DNDEBUG=1 -DTRIMMED=1 -DOS_POSIX=1 -DOS_SOLARIS=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/scratch/firefox/ipc/chromium -I/scratch/firefox/obj-x86_64-pc-solaris2.11/ipc/chromium -I/scratch/firefox/obj-x86_64-pc-solaris2.11/ipc/ipdl/_ipdlheaders -I/scratch/firefox/ipc/chromium/src -I/scratch/firefox/ipc/glue -I/scratch/firefox/obj-x86_64-pc-solaris2.11/dist/include -I/scratch/firefox/obj-x86_64-pc-solaris2.11/dist/include/nspr -I/scratch/firefox/obj-x86_64-pc-solaris2.11/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /scratch/firefox/obj-x86_64-pc-solaris2.11/mozilla-config.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wformat -fno-sized-deallocation -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fno-exceptions -fno-strict-aliasing -fno-rtti -fno-exceptions -fno-math-errno -pthread -pipe -g -O -fno-omit-frame-pointer -I/scratch/firefox/widget/gtk/compat-gtk3 -D_REENTRANT -D_POSIX_PTHREAD_SEMANTICS -D_REENTRANT -I/usr/include/gtk-3.0/unix-print -I/usr/include/gtk-3.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib/amd64/dbus-1.0/include -I/usr/include/gtk-3.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libdrm -I/usr/include/libpng14 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng14 -I/usr/include/glib-2.0 -I/usr/lib/amd64/glib-2.0/include -I/usr/include/pcre -Wno-error=shadow  -MD -MP -MF .deps/process_util_linux.o.pp   /scratch/firefox/ipc/chromium/src/base/process_util_linux.cc
/scratch/firefox/ipc/chromium/src/base/process_util_linux.cc: In function ‘bool base::LaunchApp(const std::vector<std::__cxx11::basic_string<char> >&, const base::LaunchOptions&, base::ProcessHandle*)’:
/scratch/firefox/ipc/chromium/src/base/process_util_linux.cc:39:23: error: ‘const struct base::LaunchOptions’ has no member named ‘fork_delegate’
   pid_t pid = options.fork_delegate ? options.fork_delegate->Fork() : fork();
                       ^
/scratch/firefox/ipc/chromium/src/base/process_util_linux.cc:39:47: error: ‘const struct base::LaunchOptions’ has no member named ‘fork_delegate’
   pid_t pid = options.fork_delegate ? options.fork_delegate->Fork() : fork();
                                               ^

Not sure whether it's bad but process_util_linux.cc is used on Solaris and some BSDs too:

https://searchfox.org/mozilla-central/source/ipc/chromium/moz.build#103
https://searchfox.org/mozilla-central/source/ipc/chromium/moz.build#132

The fix seems to be to extend #if to include also Solaris

https://searchfox.org/mozilla-central/source/ipc/chromium/src/base/process_util.h#124

Comment 1

[Petr Sumbera]

Attachment: Bug1434328.patch

Comment 2

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Comment on attachment 8946700 [details] [diff] [review]
Bug1434328.patch

Review of attachment 8946700 [details] [diff] [review]:
-----------------------------------------------------------------

r=me.

Alternately, you could ifdef the use of fork_delegate in LaunchApp if you wanted to remove a tiny amount of unused code — I don't think Solaris (or GNU/kFreeBSD) would ever have a use for it.  But this patch can land as-is.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7d0cb4848ed8
process_util_linux.cc with fork_delegate should build on Solaris too r=jld

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/7d0cb4848ed8