Add a checklist for adding new linters to the tree

RESOLVED FIXED in Firefox 60

Status

enhancement
RESOLVED FIXED
Last year
6 months ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

3 Branch
mozilla60

Firefox Tracking Flags

(firefox60 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

Last year
As we add new linters to the tree, we should also ensure that we have some basic requirements so that we get everything we need from the outset (or landed in a way which doesn't adversely affect developers).

We can add this into the existing linter documentation.
Comment hidden (mozreview-request)

Comment 2

Last year
mozreview-review
Comment on attachment 8946702 [details]
Bug 1434332 - Add a checklist for adding new linters to the tree.

https://reviewboard.mozilla.org/r/216672/#review222488

::: tools/lint/docs/create.rst:13
(Diff revision 1)
> +
> +* Any required dependencies should be installed as part of `./mach bootstrap`
> +* A ``./mach lint`` interface
> +* Running ``./mach lint`` command must pass (note, linters can be disabled for individual directories)
> +* Taskcluster/Treeherder integration
> +* In tree documentation (under ``lint/docs``) to give a basic summary, links and any other useful information

nit: tools/lint/docs
Attachment #8946702 - Flags: review?(ahalberstadt) → review+
See Also: → 1434337
Comment hidden (mozreview-request)

Comment 4

Last year
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/82352a076662
Add a checklist for adding new linters to the tree. r=ahal

Comment 5

Last year
bugherder
https://hg.mozilla.org/mozilla-central/rev/82352a076662
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla60

Updated

Last year
Product: Testing → Firefox Build System
Version: Version 3 → 3 Branch
You need to log in before you can comment on or make changes to this bug.