Closed Bug 1434380 Opened 3 years ago Closed 3 years ago

Adjust sizes in grid-auto-min-sizing-definite-001-ref.html to be more grounded & easier to adjust

Categories

(Core :: Layout, enhancement)

Product:
Core
Component:
Layout
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla60
Tracking Flags:
Tracking Status
firefox60 --- fixed

People

(Reporter: dholbert, Assigned: dholbert)

References

Details

Attachments

(1 file)

Bug 1434380: Rewrite parts of reftest reference case grid-auto-min-sizing-definite-001-ref.html to be easier to understand & adjust.
59 bytes, text/x-review-board-request
mats
: review+
Details 
In bug 958714, I'm going to need to adjust the values in this reference case:
https://dxr.mozilla.org/mozilla-central/source/layout/reftests/css-grid/grid-auto-min-sizing-definite-001-ref.html

...and I had a very hard time figuring out how to adjust them correctly, in part because the current sizes are a bit arbitrary & don't all correspond directly to pieces of the testcase, AFAICT.

I'm filing this bug to just to a bit of cleanup in this file (without affecting its rendering), so that the changes in 958714 can be a bit more surgical & understandable.
Comment on attachment 8946763 [details]
Bug 1434380: Rewrite parts of reftest reference case grid-auto-min-sizing-definite-001-ref.html to be easier to understand & adjust.

https://reviewboard.mozilla.org/r/216702/#review222796
Attachment #8946763 - Flags: review?(mats) → review+
Pushed by dholbert@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/57df747377cc
Rewrite parts of reftest reference case grid-auto-min-sizing-definite-001-ref.html to be easier to understand & adjust. r=mats
https://hg.mozilla.org/mozilla-central/rev/57df747377cc
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox60: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.