Closed
Bug 1434390
Opened 6 years ago
Closed 6 years ago
GetCssTextImpl can probably go away
Categories
(Core :: CSS Parsing and Computation, enhancement)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(1 file)
|
35.60 KB,
patch
|
emilio
:
review+
|
Details | Diff | Splinter Review |
We used to have a const GetCssTextImpl and a non-const GetCssText. But we should be able to just make GetCssText const everywhere and nix GetCssTextImpl.
|
Assignee | |
Comment 1•6 years ago
|
||
Looks like we can't make nsICSSDeclaration::GetCssText const...
|
||
Comment 2•6 years ago
|
||
Gah, unfortunate :(
|
|
Assignee | |
Comment 3•6 years ago
|
||
MozReview-Commit-ID: 5fejArxQckq
Attachment #8946773 -
Flags: review?(emilio)
|
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
|
|
||
Comment 4•6 years ago
|
||
Comment on attachment 8946773 [details] [diff] [review] Mostly get rid of GetCssTextImpl Review of attachment 8946773 [details] [diff] [review]: ----------------------------------------------------------------- Beautiful, thanks!
Attachment #8946773 -
Flags: review?(emilio) → review+
Pushed by bzbarsky@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/765f21b51ad2 Mostly get rid of GetCssTextImpl. r=emilio
|
||
Comment 6•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/765f21b51ad2
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•