Closed Bug 1434394 Opened 4 years ago Closed 4 years ago

No buddy_icon in history Twitter conversations.

Categories

(Thunderbird :: Instant Messaging, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 60.0

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file, 1 obsolete file)

I can't say since when the icon is not shown but now a error icon is shown instead. With TB 58 beta no icon is shown but also no error icon. Like this it was not obvious that the icon was missing.
Attached patch buddy_icon.patch (obsolete) — Splinter Review
The override does no more work and we have to re-add a buddy_icon. The icon is slightly different and packaging doesn't error with a dupe.

The themes also have now only a incoming directory. Because of this I removed the *Incoming"/"Outgoing" in the icon path and placed the icon in the main theme directory.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8946770 - Flags: review?(florian)
Comment on attachment 8946770 [details] [diff] [review]
buddy_icon.patch

Review of attachment 8946770 [details] [diff] [review]:
-----------------------------------------------------------------

::: chat/modules/imThemes.jsm
@@ -427,5 @@
>          return iconURL.spec;
>      }
>  
> -    // Fallback to the theme's default icons.
> -    return (aMsg.incoming ? "Incoming" : "Outgoing") + "/buddy_icon.png";

This was meant to reproduce exactly what Adium was doing with its message themes so that they are compatible. I don't think it's worth breaking compatibility just to avoid having an override in our jar manifest.
Attachment #8946770 - Flags: review?(florian) → review-
Attached patch buddy_icon.patchSplinter Review
Copying the buddy_icon also to Outgoing.
Attachment #8946770 - Attachment is obsolete: true
Attachment #8946979 - Flags: review?(florian)
Comment on attachment 8946979 [details] [diff] [review]
buddy_icon.patch

Review of attachment 8946979 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not sure if a duplicate file is better than an override, but r=me either way.
Attachment #8946979 - Flags: review?(florian) → review+
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/1761d9ef933c
Add the buddy_icon.png back to the Thunderbird chat theme. r=florian
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 60.0
You need to log in before you can comment on or make changes to this bug.