Include information about WebRender revision in the produced captures automatically

RESOLVED FIXED in Firefox 60

Status

()

enhancement
RESOLVED FIXED
Last year
Last year

People

(Reporter: kvark, Assigned: kvark)

Tracking

Trunk
mozilla60
Points:
---

Firefox Tracking Flags

(firefox60 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Assignee

Description

Last year
As it turns out, getting the revision and passing it along every capture is a tedious task that is begging to be automated.
Assignee

Comment 1

Last year
Posted patch Include WR revision (obsolete) — Splinter Review
This patch will conflict with any WR updates until merged!
Attachment #8946794 - Flags: review?(bugmail)
Comment on attachment 8946794 [details] [diff] [review]
Include WR revision

Review of attachment 8946794 [details] [diff] [review]:
-----------------------------------------------------------------

Commit message needs more detail. Something like "Move the WebRender revision to a separate file and include it in captures". Also remove the try syntax. For bonus points add this to your .gitconfig:

[alias]
    hgp = "show -M -C --binary --format=\"# HG changeset patch%n# User %an <%ae>%n%B\" -U8"

and then use "git hgp <cset>" to export the patch so that it will conform to the expected format for landing.

::: gfx/doc/README.webrender
@@ +178,2 @@
>  
> +The current WebRender revision can be found in gfx/webrender_bindings/revision.txt file.

Earlier in this file there is a bit that says "update the revision number at the bottom of this file" or similar, please update that text to also point to revision.txt instead
Attachment #8946794 - Flags: review?(bugmail)
Assignee

Comment 4

Last year
Thanks kats! Notes are addressed now.
Attachment #8946794 - Attachment is obsolete: true
Attachment #8946796 - Flags: review?(bugmail)
Comment on attachment 8946796 [details] [diff] [review]
Include WR revision

Review of attachment 8946796 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks. I'll land this on inbound after the current inflight WR update merges to that branch.
Attachment #8946796 - Flags: review?(bugmail) → review+

Comment 6

Last year
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/05f077d8f612
Move the WebRender revision to a separate file and include it in captures. r=kats

Comment 7

Last year
bugherder
https://hg.mozilla.org/mozilla-central/rev/05f077d8f612
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.