1434468 - Django security release 2018-02-01 (AirMoz)

Status: RESOLVED INVALID

(Webtools Graveyard :: Air Mozilla, defect)

Description

[Tristan Weir [:weir] -- use NEEDINFO for response]

CVE-2018-6188: Information leakage in AuthenticationForm
========================================================

A regression in Django 1.11.8 made
django.contrib.auth.forms.AuthenticationForm run its
confirm_login_allowed() method even if an incorrect password is entered.
This can leak information about a user, depending on what messages
confirm_login_allowed() raises. If confirm_login_allowed() isn't
overridden, an attacker enter an arbitrary username and see if that user has
been set to is_active=False. If confirm_login_allowed() is overridden,
more sensitive details could be leaked.

This issue is fixed with the caveat that AuthenticationForm can no longer
raise the "This account is inactive." error if the authentication backend
rejects inactive users (the default authentication backend, ModelBackend,
has done that since Django 1.10). This issue will be revisited for
Django 2.1 as a fix to address the caveat will likely be too invasive
for inclusion in older versions.

Affected versions
=================

* Django master development branch
* Django 2.0 and 2.0.1
* Django 1.11.8 and 1.11.9

Resolution
==========

Included with this bug are patches implementing the change described
above for each affected version of Django. On the release date, these
patches will be applied to the Django development repository and the
following releases will be issued along with disclosure of the issues:

* Django 2.0.2
* Django 1.11.10

[1] https://www.djangoproject.com/security/

Comment 1

[Tristan Weir [:weir] -- use NEEDINFO for response]

Attachment: auth-leak-master.diff

Comment 2

[Tristan Weir [:weir] -- use NEEDINFO for response]

Attachment: auth-leak-2.0.x.diff

Comment 3

[Tristan Weir [:weir] -- use NEEDINFO for response]

Attachment: auth-leak-1.11.x.diff

Comment 4

[Andy Kochendorfer]

Platform deprecated.