1434469 - Add a permission for coarse location data

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, enhancement, P2)

Description

[Mike Kaply [:mkaply]]

For some reason, the Google CTS doesn't like you requesting FINE without requesting COARSE. 

And they really don't like you requesting FINE twice (which I think we don't do anymore).

We should add the COARSE permission. It won't affect anything and will allow us to better pass the CTS.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

To be clear, I think this bug is about updating the AndroidManifest so it declares both coarse and fine location access.

[triage] iiuc, seems non-critical but if Jim is going to fix it, wfm. Please mark P3 if you decide not to though.

Comment 2

[Mike Kaply [:mkaply]]

Yes, that is correct. We should declare both (and make sure we don't declare FINE twice which I think was fixed when we removed the search widget).

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Bug 1434469 - Add ACCESS_COARSE_LOCATION to list of permissions;

Add ACCESS_COARSE_LOCATION to the Fennec and GeckoView list of
permissions. For completeness, also add ACCESS_COARSE_LOCATION to JS
modules that handle runtime permissions.

Review commit: https://reviewboard.mozilla.org/r/219906/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/219906/

Comment 4

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8950659 [details]
Bug 1434469 - Add ACCESS_COARSE_LOCATION to list of permissions;

https://reviewboard.mozilla.org/r/219906/#review225744

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/12e36be8f260
Add ACCESS_COARSE_LOCATION to list of permissions; r=snorp

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/12e36be8f260