Closed
Bug 1434546
Opened 6 years ago
Closed 6 years ago
Reduce the length of time that atomization holds the exclusive access lock
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: jonco, Assigned: jonco)
Details
Attachments
(1 file)
|
3.46 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
If AtomizeAndCopyChars needs to take the exclusive access lock it holds on to it while marking the new atom and adding it to the per-zone cache. This unnecessarily increases the length of time this lock is held for.
|
Assignee | |
Comment 1•6 years ago
|
||
Patch to reduce the length of time the lock is held for.
Attachment #8947040 -
Flags: review?(jdemooij)
|
||
Comment 2•6 years ago
|
||
Comment on attachment 8947040 [details] [diff] [review] bug1434546-shorter-atoms-lock Review of attachment 8947040 [details] [diff] [review]: ----------------------------------------------------------------- Nice!
Attachment #8947040 -
Flags: review?(jdemooij) → review+
Pushed by jcoppeard@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/2bda1bbb8d22 Reduce the length of time we hold the exclusive access lock while atomizing a string r=jandem
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/2bda1bbb8d22
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•