1434664 - [mozdevice] Should use posixpath.normpath for determining remote pathnames

Status: RESOLVED FIXED

(Testing :: Mozbase, enhancement, P1)

Description

[William Lachance (:wlach)]

Based on the log in https://bugzilla.mozilla.org/show_bug.cgi?id=1431403#c16, I think mozdevice's push/pull methods are not working on Windows. Using sys.path.normpath will turn a pathname into a Windows pathname, which is not what we want here.

Historically we have not supported Windows in mozdevice. I don't particularly care about changing that assumption, but I'd like mozregression to work for Android bisection so think we should patch this up, especially since it's little work. Hopefully it's the only issue...

Comment 1

[William Lachance (:wlach)]

Attachment: Bug 1434664 - Fix mozdevice's pull/push methods on Windows

We should use posixpath's normpath for calculating the remote
(i.e. device path) with these methods.

Review commit: https://reviewboard.mozilla.org/r/216942/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/216942/

Comment 2

[William Lachance (:wlach)]

Attachment: Bug 1434664 - Bump mozdevice to 0.52

Review commit: https://reviewboard.mozilla.org/r/217616/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/217616/

Comment 3

[William Lachance (:wlach)]

Comment on attachment 8947169 [details]
Bug 1434664 - Fix mozdevice's pull/push methods on Windows

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/216942/diff/1-2/

Comment 4

[William Lachance (:wlach)]

Woohoo, I verified that the change fixes mozregression on Windows (bug 1431403). On to bc to review...

Comment 5

[Bob Clary [:bc] (inactive)]

Comment on attachment 8947169 [details]
Bug 1434664 - Fix mozdevice's pull/push methods on Windows

https://reviewboard.mozilla.org/r/216942/#review223410

Nice. r+

Comment 6

[Bob Clary [:bc] (inactive)]

Comment on attachment 8947938 [details]
Bug 1434664 - Bump mozdevice to 0.52

https://reviewboard.mozilla.org/r/217616/#review223412

r+

Comment 7

[Bob Clary [:bc] (inactive)]

Do we want to go ahead and do devicemanagerADB.py as well? There are a couple of os.path.normpath calls in there, but if it is never used on Windows it doesn't really matter. Thanks!

Comment 8

[William Lachance (:wlach)]

(In reply to Bob Clary [:bc:] from comment #7)
> Do we want to go ahead and do devicemanagerADB.py as well? There are a
> couple of os.path.normpath calls in there, but if it is never used on
> Windows it doesn't really matter. Thanks!

Yeah, the only motivation for using devicemanagerADB on Windows would be to run mochitest/reftest for android on that platform, and I'm sure there's a pile of other reasons that won't work right now. Let's just skip it and do the minimal thing here.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/82b26c23e07b
Fix mozdevice's pull/push methods on Windows r=bc
https://hg.mozilla.org/integration/autoland/rev/8b359f41473b
Bump mozdevice to 0.52 r=bc

Comment 10

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/82b26c23e07b
https://hg.mozilla.org/mozilla-central/rev/8b359f41473b