Closed Bug 1434683 Opened 6 years ago Closed 6 years ago

Convert angular providers that React code is using into shared or pure react code

Categories

(Tree Management :: Treeherder: Frontend, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: camd, Assigned: camd)

References

Details

The React components currently have to the the angular $injector to get access to several providers that should be converted to React.  Some examples:

    this.$rootScope = this.props.$injector.get('$rootScope');
    this.$location = this.props.$injector.get('$location');
    this.thEvents = this.props.$injector.get('thEvents');
    this.ThResultSetStore = this.props.$injector.get('ThResultSetStore');
    this.ThJobModel = this.props.$injector.get('ThJobModel');
    this.thUrl = this.props.$injector.get('thUrl');
    this.thJobFilters = this.props.$injector.get('thJobFilters');
    this.thResultStatus = this.props.$injector.get('thResultStatus');
    this.thResultStatusInfo = this.props.$injector.get('thResultStatusInfo');

Some of these will be easier than others.  $rootScope should be the last and will likely need to happen once the entire app is converted.  Others like thJobFilters, thResultStatus and thResultStatusInfo will be easier
These are now no longer used by Treeherder itself.  Perfherder and Logviewer conversion will be handled in other bugs.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Assignee: nobody → cdawson
You need to log in before you can comment on or make changes to this bug.