1434724 - 'font-feature-settings: "vert" 0' gets serialized as '"vert" off' which means the same thing but is longer and disagrees with other browsers.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Daniel Holbert [:dholbert]]

(Spinning this off from bug 1434698)

STR:
 1. Open https://jsfiddle.net/f956aoLm/
 2. Open web console (Ctrl-Shift-K)

EXPECTED RESULTS:
web console should show: "vert" 0

ACTUAL RESULTS:
web console shows: "vert" off

REASONING:
 - Web compatibility (Chrome, Edge, and Safari all do this)
 - off and 0 are synonymous, and per https://github.com/w3c/csswg-drafts/issues/1564 there's a general principle that css syntax should be serialized using the shortest possible syntax. (And clearly "0" is shorter)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Will fix this as part of bug 1434692, while I'm at it.

Comment 2

[Phabricator Automation]

Comment on attachment 8947329 [details]
Fix computed value serialization of font-feature-settings.

Daniel Holbert [:dholbert] has approved the revision.

https://phabricator.services.mozilla.com/D539#11985

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/946b943acc04
Fix computed value serialization of font-feature-settings. r=dholbert

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/946b943acc04