1434747 - Add a reftest for async-scrolling of fixed content inside a CSS filter

Status: RESOLVED FIXED

(Core :: Panning and Zooming, enhancement)

Description

[Botond Ballo [:botond]]

As we discovered in bug 1404218, async scrolling of fixed content inside a CSS filter works correctly with WebRender enabled because WebRender implements applying CSS filters in the compositor, so we don't need to flatten the fixed and non-fixed content together on the main thread the way we do with the Gecko compositor.

Kats suggested adding a WR-only reftest for this, to make sure we don't regress it with WR.

Comment 1

[Botond Ballo [:botond]]

Attachment: Bug 1434747 - Add a reftest for async-scrolling of fixed content inside a CSS filter.

The test only passes with WebRender enabled. Passing without WebRender
would require implementing CSS filters in the Gecko compositor.

Review commit: https://reviewboard.mozilla.org/r/217002/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/217002/

Comment 2

[Botond Ballo [:botond]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=48633ac12538046f25bd0ef695af18ac6dc61a7b

Comment 3

[Botond Ballo [:botond]]

Comment on attachment 8947249 [details]
Bug 1434747 - Add a reftest for async-scrolling of fixed content inside a CSS filter.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/217002/diff/1-2/

Comment 4

[Botond Ballo [:botond]]

Comment on attachment 8947249 [details]
Bug 1434747 - Add a reftest for async-scrolling of fixed content inside a CSS filter.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/217002/diff/2-3/

Comment 5

[Botond Ballo [:botond]]

Looks good except for "Windows 10 x64 cc" failures which I assume are unrelated.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8947249 [details]
Bug 1434747 - Add a reftest for async-scrolling of fixed content inside a CSS filter.

https://reviewboard.mozilla.org/r/217002/#review222896

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0e9c332262ab
Add a reftest for async-scrolling of fixed content inside a CSS filter. r=kats

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/0e9c332262ab