Closed Bug 1434772 Opened 4 years ago Closed 4 years ago

test to ensure CacheStorage is disabled in Private Browsing mode

Categories

(Core :: DOM: Core & HTML, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: arthur, Assigned: arthur)

References

(Blocks 1 open bug)

Details

(Whiteboard: [tor 18995])

Attachments

(1 file)

In Tor Browser we have a mochitest designed to confirm that whether CacheStorage is disabled in Private Browsing windows. We'd like to propose uplifting this patch.

Here's the patch:
https://torpat.ch/18995
And the original ticket:
https://trac.torproject.org/18995
Some of the patch doesn't need to be uplifted because of the tests in
https://dxr.mozilla.org/mozilla-central/rev/0d806b3230fe4767fa70cdee57db87d1e9a5ba49/dom/cache/test/mochitest/browser_cache_pb_window.js
but we could add a worker test.
Here's a patch that covers the additional mochitest in Tor Browser.

try results: https://treeherder.mozilla.org/#/jobs?repo=try&revision=fc6ccce960c0
Assignee: nobody → arthuredelstein
Attachment #8950696 - Flags: review?(ehsan)
Priority: -- → P2
Comment on attachment 8950696 [details] [diff] [review]
0001-Bug-1434772-Ensure-caches.open-throws-SecurityError-.patch

Review of attachment 8950696 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, sorry for my delay in getting back to you!
Attachment #8950696 - Flags: review?(ehsan) → review+
No problem -- thanks for the review!
Keywords: checkin-needed
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a5e59d9a81f9
Ensure caches.open() throws SecurityError in PBM workers r=ehsan
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/a5e59d9a81f9
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.