1434772 - test to ensure CacheStorage is disabled in Private Browsing mode

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P2)

Description

[Arthur Edelstein [:arthur]]

In Tor Browser we have a mochitest designed to confirm that whether CacheStorage is disabled in Private Browsing windows. We'd like to propose uplifting this patch.

Here's the patch:
https://torpat.ch/18995
And the original ticket:
https://trac.torproject.org/18995

Comment 1

[Arthur Edelstein [:arthur]]

Some of the patch doesn't need to be uplifted because of the tests in
https://dxr.mozilla.org/mozilla-central/rev/0d806b3230fe4767fa70cdee57db87d1e9a5ba49/dom/cache/test/mochitest/browser_cache_pb_window.js
but we could add a worker test.

Comment 2

[Arthur Edelstein [:arthur]]

Attachment: 0001-Bug-1434772-Ensure-caches.open-throws-SecurityError-.patch

Here's a patch that covers the additional mochitest in Tor Browser.

try results: https://treeherder.mozilla.org/#/jobs?repo=try&revision=fc6ccce960c0

Comment 3

[(no longer active)]

Comment on attachment 8950696 [details] [diff] [review]
0001-Bug-1434772-Ensure-caches.open-throws-SecurityError-.patch

Review of attachment 8950696 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, sorry for my delay in getting back to you!

Comment 4

[Arthur Edelstein [:arthur]]

No problem -- thanks for the review!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a5e59d9a81f9
Ensure caches.open() throws SecurityError in PBM workers r=ehsan

Comment 6

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/a5e59d9a81f9