Closed Bug 1434777 Opened 5 years ago Closed 5 years ago

Intermittent toolkit/components/extensions/test/mochitest/test-oop-extensions/test_ext_contentscript_devtools_metadata.html | Test timed out.

Categories

(WebExtensions :: General, defect)

Product:
WebExtensions
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: intermittent-bug-filer, Assigned: rpl)

References

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell fixed:product])

Attachments

(2 files, 1 obsolete file)

disable_bug1434777.patch
954 bytes, patch
jmaher
: review+
Details | Diff | Splinter Review
Bug 1434777 - Re-enabled test_ext_contentscript_devtools_metadata.html test on Windows.
59 bytes, text/x-review-board-request
jmaher
: review+
Details 
Filed by: csabou [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=159605207&repo=autoland

https://queue.taskcluster.net/v1/task/GINaRZJ6Rzmb-vzIzA7EaQ/runs/0/artifacts/public/logs/live_backing.log

14503 17:15:19 ERROR - 1348 INFO TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/mochitest/test-oop-extensions/test_ext_contentscript_devtools_metadata.html | Test timed out.
14527 17:15:20 ERROR - 1349 INFO TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/mochitest/test-oop-extensions/test_ext_contentscript_devtools_metadata.html | Extension left running at test shutdown
14557 17:15:49 ERROR - 1350 INFO TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/mochitest/test-oop-extensions/test_ext_contentscript_devtools_metadata.html | Test timed out.
14595 17:21:19 ERROR - 1356 INFO TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/mochitest/test-oop-extensions/test_ext_contentscript_exporthelpers.html | Test timed out.
14631 17:21:20 ERROR - 1357 INFO TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/mochitest/test-oop-extensions/test_ext_contentscript_exporthelpers.html | Extension left running at test shutdown
14673 17:21:49 ERROR - 1358 INFO TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/mochitest/test-oop-extensions/test_ext_contentscript_exporthelpers.html | Test timed out.
14710 17:21:49 ERROR - 1359 INFO TEST-UNEXPECTED-FAIL | (SimpleTest/TestRunner.js) | 4 test timeouts, giving up.
14747 17:21:49 ERROR - 1360 INFO TEST-UNEXPECTED-FAIL | (SimpleTest/TestRunner.js) | Skipping 62 remaining tests.
14786 17:21:50 ERROR - 1362 INFO TEST-UNEXPECTED-FAIL | (SimpleTest/TestRunner.js) | /tests/toolkit/components/extensions/test/mochitest/test-oop-extensions/test_ext_contentscript_exporthelpers.html - finished in a non-clean fashion, probably because it didn't call SimpleTest.finish()
14788 17:21:50 ERROR - 1363 INFO TEST-UNEXPECTED-ERROR | (SimpleTest/TestRunner.js) | Finished in 359978ms
16907 17:31:32 ERROR - # TBPL FAILURE #
16909 17:31:32 ERROR - The mochitest suite: plain-chunked ran with return status: FAILURE
Looking at the logs from the failures, the reason for the timeout seems to be related to this error message (https://treeherder.mozilla.org/logviewer.html#?job_id=159710133&repo=autoland&lineNumber=14459):

     JavaScript error: resource://testing-common/ExtensionTestCommon.jsm, line 268: NS_ERROR_FILE_ACCESS_DENIED: Component returned failure code: 0x80520015 (NS_ERROR_FILE_ACCESS_DENIED) [nsIFile.createUnique]

and it seems that there is more than one test that is triggering this issue on Window,
Shane has created an issue to track the other bugzilla issues that seems to be related to this error message
as Bug 1435100, I'm going to add this one to that list.
Blocks: 1435100
Flags: needinfo?(lgreco)
No longer blocks: 1435100
Depends on: 1435100
There were 42 failure in the past week, on Windows 10-64 and Windows 7 platforms, opt and debug build type mostly.

Link to recent log file: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-central&job_id=161632094

Part of that log: 
23:53:36    ERROR -  1350 INFO TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/mochitest/test-oop-extensions/test_ext_contentscript_devtools_metadata.html | Test timed out.
23:53:36     INFO -      reportError@SimpleTest/TestRunner.js:121:7
23:53:36     INFO -      TestRunner._checkForHangs@SimpleTest/TestRunner.js:142:7
23:53:36     INFO -      setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
23:53:36     INFO -      setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
23:53:36     INFO -      setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
23:53:36     INFO -      setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
23:53:36     INFO -      setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
23:53:36     INFO -      setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
23:53:36     INFO -      setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
23:53:36     INFO -      setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
23:53:36     INFO -      setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
23:53:36     INFO -      setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
23:53:36     INFO -      setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
23:53:36     INFO -      TestRunner.runTests@SimpleTest/TestRunner.js:380:5
23:53:36     INFO -      RunSet.runtests@SimpleTest/setup.js:194:3
23:53:36     INFO -      RunSet.runall@SimpleTest/setup.js:173:5
23:53:36     INFO -      hookupTests@SimpleTest/setup.js:266:5
23:53:36     INFO -  parseTestManifest@http://mochi.test:8888/manifestLibrary.js:36:5
Flags: needinfo?(ddurst)
Attached patch disable_bug1434777.patch (obsolete) — — Splinter Review 
Could please take a look at this patch and see if it's ok? Thanks. 

+skip-if = os == 'win' && (os_version == '6.1' || os_version == '10.0') # bug 1434777
Attachment #8951546 - Flags: review?(jmaher)
Comment on attachment 8951546 [details] [diff] [review]
disable_bug1434777.patch

Review of attachment 8951546 [details] [diff] [review]:
-----------------------------------------------------------------

please make the change to simplify this.

::: toolkit/components/extensions/test/mochitest/mochitest-common.ini
@@ +86,4 @@
>  [test_ext_contentscript_create_iframe.html]
>  [test_ext_contentscript_css.html]
>  [test_ext_contentscript_devtools_metadata.html]
> +skip-if = os == 'win' && (os_version == '6.1' || os_version == '10.0') # bug 1434777

we only run tests on win7/win10, so os == 'win' is enough
Attachment #8951546 - Flags: review?(jmaher) → review-
Had a hunch about that but wanted to be sure since I saw Windows 2012 in Treeherder. Now I realise those are only builds. Thanks for the review.
Attachment #8951546 - Attachment is obsolete: true
Attachment #8951560 - Flags: review?(jmaher)
Attachment #8951560 - Flags: review?(jmaher) → review+
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a81d9de925d8
Disabled toolkit/components/extensions/test/mochitest/test-oop-extensions/test_ext_contentscript_devtools_metadata.html for frequent failures. r=jmaher
Keywords: checkin-needed
Keywords: leave-open
Whiteboard: [stockwell disable-recommended] → [stockwell disabled]
Comment on attachment 8955460 [details]
Bug 1434777 - Re-enabled test_ext_contentscript_devtools_metadata.html test on Windows.

https://reviewboard.mozilla.org/r/224620/#review230624

::: toolkit/components/extensions/test/mochitest/mochitest-common.ini
(Diff revision 1)
>  [test_ext_contentscript_canvas.html]
>  [test_ext_contentscript_context.html]
>  [test_ext_contentscript_create_iframe.html]
>  [test_ext_contentscript_css.html]
>  [test_ext_contentscript_devtools_metadata.html]
> -skip-if = os == 'win' # bug 1434777

Hi Joel,
this intermittent test (disabled in Comment 13) should have been now fixed by Bug 1435100, and we'd like to re-enable it.

The fix for Bug 1435100 landed during the past week on both mozilla-central (landed on Feb 22) and on mozilla-beta (landed on Feb 23) and it should have also fixed the intermittency of this test,
while I was testing the fix from Bug 1435100 I also re-enabled this test file (and the test disabled by Bug 1434590) in some try pushes (to have an higher chance to trigger the issue and also to confirm that we were fixing the actual underlying issue also for the tests that have been disabled in the meantime), e.g. this test was re-enabled in the following two try pushes:

- https://treeherder.mozilla.org/#/jobs?repo=try&revision=f06c507ec0bc9e3e507732bc9ea8849f33d0f9d4
- https://treeherder.mozilla.org/#/jobs?repo=try&revision=5bf8a8005fbbc5877c87666b3c6df9469d4f7685

(we are also keeping an eye on the group of intermittents that should have been fixed by Bug 1435100 using the
following Jupyter Notebook: https://gist.github.com/rpl/84a1d5c89142dd8660e88d699caa69e3)
Flags: needinfo?(ddurst)
Comment on attachment 8955460 [details]
Bug 1434777 - Re-enabled test_ext_contentscript_devtools_metadata.html test on Windows.

https://reviewboard.mozilla.org/r/224622/#review230640

thanks
Attachment #8955460 - Flags: review?(jmaher) → review+
Pushed by luca.greco@alcacoop.it:
https://hg.mozilla.org/integration/autoland/rev/67fb62fd00b4
Re-enabled test_ext_contentscript_devtools_metadata.html test on Windows. r=jmaher
Assignee: nobody → lgreco
Status: NEW → ASSIGNED
Whiteboard: [stockwell disabled] → [stockwell]
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Keywords: leave-open
Resolution: --- → FIXED
Whiteboard: [stockwell] → [stockwell fixed:product]
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.