Closed Bug 1434789 Opened 6 years ago Closed 6 years ago

Get rid of nsSubstringTuple.(h|cpp)

Categories

(Core :: XPCOM, enhancement)

Product:
Core
Component:
XPCOM
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla60
Tracking Flags:
Tracking Status
firefox60 --- fixed

People

(Reporter: erahm, Assigned: erahm)

Details

Attachments

(2 files)

Part 1: Remove unnecessary nsSubstringTuple.h includes
1.76 KB, patch
froydnj
: review+
Details | Diff | Splinter Review
Part 2: Remove nsSubstringTuple aliases
2.68 KB, patch
froydnj
: review+
Details | Diff | Splinter Review 
We should get rid of nsStringTuple.(h|cpp), we can just use nsTStringTuple.(h|cpp) directly instead.
Summary: Get rid of nsStringTuple.(h|cpp) → Get rid of nsSubstringTuple.(h|cpp)
This removes nsSubstringTuple.h and nsSubstringTuple.cpp in favor of
nsTSubstringTuple.
Attachment #8947320 - Flags: review?(nfroyd)
Attachment #8947319 - Flags: review?(nfroyd) → review+
Comment on attachment 8947320 [details] [diff] [review]
Part 2: Remove nsSubstringTuple aliases

Review of attachment 8947320 [details] [diff] [review]:
-----------------------------------------------------------------

Makes sense to me.
Attachment #8947320 - Flags: review?(nfroyd) → review+
Pushed by erahm@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5616e5860bfe
Part 1: Remove unnecessary nsSubstringTuple.h includes. r=froydnj
https://hg.mozilla.org/integration/mozilla-inbound/rev/3503512d062a
Part 2: Remove nsSubstringTuple aliases. r=froydnj
https://hg.mozilla.org/mozilla-central/rev/5616e5860bfe
https://hg.mozilla.org/mozilla-central/rev/3503512d062a
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Component: String → XPCOM
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: