Open Bug 1434825 Opened 2 years ago Updated 2 years ago

The printing reftests are not run

Categories

(Core :: Printing: Output, defect, P2)

defect

Tracking

()

People

(Reporter: glandium, Unassigned)

References

Details

Kind of irrelevant, but for the little story, in bug 1432310, :past made a mistake using a #ifdef clause for a comparison, which raised the interesting point that the preprocessor would gladly accept the syntax and silently fail the test (because obviously, there isn't a #define for a name that looks like a comparison), which led us to file and fix bug 1434765.

In turn, that unveiled a similar problem with a #ifdef that bug 1299848 added to layout/tools/reftest/reftest.jsm and that bug 1405349 moved to layout/tools/reftest/manifest.jsm.

So my first attempt was to fix that broken #ifdef, but it turns out those tests, that actually were always skipped because of the error, are busted:

20:44:40    ERROR - TEST-UNEXPECTED-FAIL | file:///Users/cltbld/tasks/task_1517451959/build/tests/reftest/tests/layout/reftests/printing/test-text.html | application terminated with exit code 5
20:44:40     INFO - REFTEST INFO | Copy/paste: /Users/cltbld/tasks/task_1517451959/build/macosx64-minidump_stackwalk /var/folders/4g/b0nbvg4x5nz0scptgwhfs4fm00000w/T/tmpcafbYb.mozrunner/minidumps/03E7B8E6-4A53-484E-B756-732BEF3D7BAE.dmp /Users/cltbld/tasks/task_1517451959/build/symbols
20:44:56     INFO - REFTEST INFO | Saved minidump as /Users/cltbld/tasks/task_1517451959/build/blobber_upload_dir/03E7B8E6-4A53-484E-B756-732BEF3D7BAE.dmp
20:44:56     INFO - REFTEST INFO | Saved app info as /Users/cltbld/tasks/task_1517451959/build/blobber_upload_dir/03E7B8E6-4A53-484E-B756-732BEF3D7BAE.extra
20:44:57     INFO - REFTEST PROCESS-CRASH | file:///Users/cltbld/tasks/task_1517451959/build/tests/reftest/tests/layout/reftests/printing/test-text.html | application crashed [@ mach_msg_trap + 0xa]
20:44:57     INFO - Crash dump filename: /var/folders/4g/b0nbvg4x5nz0scptgwhfs4fm00000w/T/tmpcafbYb.mozrunner/minidumps/03E7B8E6-4A53-484E-B756-732BEF3D7BAE.dmp
20:44:57     INFO - Operating system: Mac OS X
20:44:57     INFO -                   10.10.5 14F27
20:44:57     INFO - CPU: amd64
20:44:57     INFO -      family 6 model 69 stepping 1
20:44:57     INFO -      4 CPUs
20:44:57     INFO - 
20:44:57     INFO - GPU: UNKNOWN
20:44:57     INFO - 
20:44:57     INFO - Crash reason:  EXC_SOFTWARE / SIGABRT
20:44:57     INFO - Crash address: 0x7fff8c24f4de
20:44:57     INFO - Process uptime: 1268 seconds
20:44:57     INFO - 
20:44:57     INFO - Thread 0 (crashed)
20:44:57     INFO -  0  libsystem_kernel.dylib!mach_msg_trap + 0xa
20:44:57     INFO -     rax = 0x0000000010004005   rdx = 0x0000000000000000
20:44:57     INFO -     rcx = 0x00007fff5c8936a8   rbx = 0x00000000ffffffff
20:44:57     INFO -     rsi = 0x0000000007000806   rdi = 0x00007fff5c893810
20:44:57     INFO -     rbp = 0x00007fff5c8936f0   rsp = 0x00007fff5c8936a8
20:44:57     INFO -      r8 = 0x000000000000230b    r9 = 0x00000000ffffffff
20:44:57     INFO -     r10 = 0x0000000000000c00   r11 = 0x0000000000000206
20:44:57     INFO -     r12 = 0x0000000000000c00   r13 = 0x0000000000000000
20:44:57     INFO -     r14 = 0x00007fff5c893810   r15 = 0x000000000000230b
20:44:57     INFO -     rip = 0x00007fff8c24f4de
20:44:57     INFO -     Found by: given as instruction pointer in context
20:44:57     INFO -  1  CoreFoundation!__CFRunLoopServiceMachPort + 0xd4
20:44:57     INFO -     rbp = 0x00007fff5c893760   rsp = 0x00007fff5c893700
20:44:57     INFO -     rip = 0x00007fff8c7b1eb4
20:44:57     INFO -     Found by: previous frame's frame pointer
20:44:57     INFO -  2  CoreFoundation!__CFRunLoopRun + 0x55b
20:44:57     INFO -     rbp = 0x00007fff5c894440   rsp = 0x00007fff5c893770
20:44:57     INFO -     rip = 0x00007fff8c7b137b
20:44:57     INFO -     Found by: previous frame's frame pointer
20:44:57     INFO -  3  CoreFoundation!CFRunLoopRunSpecific + 0x128
20:44:57     INFO -     rbp = 0x00007fff5c8944a0   rsp = 0x00007fff5c894450
20:44:57     INFO -     rip = 0x00007fff8c7b0bd8
20:44:57     INFO -     Found by: previous frame's frame pointer
20:44:57     INFO -  4  HIToolbox + 0x3256f
20:44:57     INFO -     rbp = 0x00007fff5c8944e0   rsp = 0x00007fff5c8944b0
20:44:57     INFO -     rip = 0x00007fff85c6e56f
20:44:57     INFO -     Found by: previous frame's frame pointer
20:44:57     INFO -  5  HIToolbox + 0x322ea
20:44:57     INFO -     rbp = 0x00007fff5c894560   rsp = 0x00007fff5c8944f0
20:44:57     INFO -     rip = 0x00007fff85c6e2ea
20:44:57     INFO -     Found by: previous frame's frame pointer
20:44:57     INFO -  6  HIToolbox + 0x3212b
20:44:57     INFO -     rbp = 0x00007fff5c894580   rsp = 0x00007fff5c894570
20:44:57     INFO -     rip = 0x00007fff85c6e12b
20:44:57     INFO -     Found by: previous frame's frame pointer
20:44:57     INFO -  7  AppKit!_DPSNextEvent + 0x3d2
20:44:57     INFO -     rbp = 0x00007fff5c8949f0   rsp = 0x00007fff5c894590
20:44:57     INFO -     rip = 0x00007fff915448ab
20:44:57     INFO -     Found by: previous frame's frame pointer
20:44:57     INFO -  8  AppKit!-[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 0x15a
20:44:57     INFO -     rbp = 0x00007fff5c894c90   rsp = 0x00007fff5c894a00
20:44:57     INFO -     rip = 0x00007fff91543e58
20:44:57     INFO -     Found by: previous frame's frame pointer
20:44:57     INFO -  9  XUL!-[GeckoNSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] [nsAppShell.mm:ac1ff22bffd6 : 158 + 0x2c]
20:44:57     INFO -     rbp = 0x00007fff5c894ce0   rsp = 0x00007fff5c894ca0
20:44:57     INFO -     rip = 0x0000000106a63746
20:44:57     INFO -     Found by: previous frame's frame pointer
20:44:57     INFO - 10  AppKit!-[NSApplication run] + 0x252
20:44:57     INFO -     rbx = 0x0000000120efc480   rbp = 0x00007fff5c894d60
20:44:57     INFO -     rsp = 0x00007fff5c894cf0   r12 = 0x0000000000000000
20:44:57     INFO -     r13 = 0x000000011729fd90   r14 = 0x000000011729fd90
20:44:57     INFO -     r15 = 0x00007f9654003401   rip = 0x00007fff91539af3
20:44:57     INFO -     Found by: call frame info
20:44:57     INFO - 11  XUL!nsAppShell::Run() [nsAppShell.mm:ac1ff22bffd6 : 715 + 0x1a]
20:44:57     INFO -     rbp = 0x00007fff5c894da0   rsp = 0x00007fff5c894d70
20:44:57     INFO -     rip = 0x0000000106a64ced
20:44:57     INFO -     Found by: previous frame's frame pointer
20:44:57     INFO - 12  XUL!nsAppStartup::Run() [nsAppStartup.cpp:ac1ff22bffd6 : 288 + 0x6]
20:44:57     INFO -     rbx = 0x000000010eb25fb0   rbp = 0x00007fff5c894dc0
20:44:57     INFO -     rsp = 0x00007fff5c894db0   r14 = 0x00007fff5c894e88
20:44:57     INFO -     r15 = 0x000000010adee790   rip = 0x000000010824ee26
20:44:57     INFO -     Found by: call frame info
20:44:57     INFO - 13  XUL!XREMain::XRE_mainRun() [nsAppRunner.cpp:ac1ff22bffd6 : 4707 + 0x6]
20:44:57     INFO -     rbx = 0x0000000000000003   rbp = 0x00007fff5c894f10
20:44:57     INFO -     rsp = 0x00007fff5c894dd0   r14 = 0x00007fff5c894e88
20:44:57     INFO -     r15 = 0x000000010adee790   rip = 0x00000001083371b6
20:44:57     INFO -     Found by: call frame info
20:44:57     INFO - 14  XUL!XREMain::XRE_main(int, char**, mozilla::BootstrapConfig const&) [nsAppRunner.cpp:ac1ff22bffd6 : 4842 + 0x8]
20:44:57     INFO -     rbx = 0x0000000000000001   rbp = 0x00007fff5c894fa0
20:44:57     INFO -     rsp = 0x00007fff5c894f20   r12 = 0x0000000103a5cf80
20:44:57     INFO -     r13 = 0x0000000000000000   r14 = 0x00007fff5c894f58
20:44:57     INFO -     r15 = 0x00007fff5c894fb8   rip = 0x00000001083382c0
20:44:57     INFO -     Found by: call frame info
20:44:57     INFO - 15  XUL!XRE_main(int, char**, mozilla::BootstrapConfig const&) [nsAppRunner.cpp:ac1ff22bffd6 : 4934 + 0x10]
20:44:57     INFO -     rbx = 0x0000000000000005   rbp = 0x00007fff5c895130
20:44:57     INFO -     rsp = 0x00007fff5c894fb0   r12 = 0x00007fff5c894fb8
20:44:57     INFO -     r13 = 0x0000066deb155ebd   r14 = 0x00007fff5c895150
20:44:57     INFO -     r15 = 0x00007fff5c8955a0   rip = 0x0000000108338977
20:44:57     INFO -     Found by: call frame info
20:44:57     INFO - 16  firefox!main [nsBrowserApp.cpp:ac1ff22bffd6 : 231 + 0x13]
20:44:57     INFO -     rbx = 0x0000000000000000   rbp = 0x00007fff5c895580
20:44:57     INFO -     rsp = 0x00007fff5c895140   r12 = 0x00007fff5c8955a0
20:44:57     INFO -     r13 = 0x0000066deb155ebd   r14 = 0x0000000000000005
20:44:57     INFO -     r15 = 0x0000000000000000   rip = 0x000000010336aeda
20:44:57     INFO -     Found by: call frame info
20:44:57     INFO - 17  firefox!start + 0x34
20:44:57     INFO -     rbx = 0x0000000000000000   rbp = 0x00007fff5c895590
20:44:57     INFO -     rsp = 0x00007fff5c895590   r12 = 0x0000000000000000
20:44:57     INFO -     r13 = 0x0000000000000000   r14 = 0x0000000000000000
20:44:57     INFO -     r15 = 0x0000000000000000   rip = 0x000000010336ab04
20:44:57     INFO -     Found by: call frame info
(snip)

This may well have been happening since day one, since the tests have always been skipped.

So bug 1434765 simply removed the broken #ifdef and the corresponding branch, like this:

-// Printing via Skia PDF is only supported on Mac for now.
-#ifdef XP_MACOSX && MOZ_ENABLE_SKIA_PDF
-    sandbox.skiaPdf = true;
-#else
     sandbox.skiaPdf = false;
-#endif

The right way to do this would be #if defined(XP_MACOSX) && defined(MOZ_ENABLE_SKIA_PDF), which is what I had pushed to try giving me the above crash.
Priority: -- → P2
Summary: REFTEST PROCESS-CRASH | file:///Users/cltbld/tasks/task_1517451959/build/tests/reftest/tests/layout/reftests/printing/test-text.html | application crashed [@ mach_msg_trap + 0xa] → The printing reftests are not run
You need to log in before you can comment on or make changes to this bug.