Closed Bug 1434837 Opened 2 years ago Closed 2 years ago

autocomplete should listen to keypress events at the system event group

Categories

(Toolkit :: Autocomplete, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

References

(Depends on 1 open bug)

Details

Attachments

(1 file)

We'll stop dispatching keypress events for non-printable keys and non-printable key combinations. Therefore, autocomplete should stop using keypress events to handle such keys and key combinations.
Priority: -- → P1
Hmm, if we change some part of keypress event listeners to keydown event listeners, the order of key event listeners are changed between other modules. That causes a lot of oranges which are difficult to understand. Without event listener order debugging system, we cannot use such ideal approach...

So, perhaps, we should just use keypress event listeners at the system event group for now, unfortunately.
OS: Unspecified → All
Hardware: Unspecified → All
Summary: autocomplete should handle keydown event if it needs to handle non-printable key or key combination → autocomplete should listen to keypress events at the system event group
Version: unspecified → Trunk
Comment on attachment 8950533 [details]
Bug 1434837 - Make autocomplete and satchel listen to keypress event at the system event group

https://reviewboard.mozilla.org/r/219806/#review227218

LGTM, thanks!

::: toolkit/content/tests/chrome/test_autocomplete_mac_caret.xul:63
(Diff revision 1)
> +  }, {once: true});
> +  synthesizeKey(key, {});
> +  if (result) {
> +    ok(keypressFired, testid + " keypress event should be fired");
> +  } else {
> +    ok(!keypressFired, testid + " keypress event shouldn't be fired");

nit: you could probably unify these:
is(keypressFired, result,
   `${testid} keypress event should${result ? "" : " not"} be fired`);
Attachment #8950533 - Flags: review?(mak77) → review+
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/c0b4ca69376c
Make autocomplete and satchel listen to keypress event at the system event group r=mak
https://hg.mozilla.org/mozilla-central/rev/c0b4ca69376c
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Depends on: 1449018
Regressions: 1490428
You need to log in before you can comment on or make changes to this bug.