1434911 - NS_OpenAnonymousTemporaryNsIFile should create files as 0600 instead of 0700

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement, P1)

Description

[Alex Gaynor [:Alex_Gaynor]]

Currently files created by NS_OpenAnonymousTemporaryNsIFile have 0700 permissions. None of the consumers I see have any need for the executable bit, so we should drop it and use 0600 instead.

There's no particular attack this is preventing, just a general principle of least permission - no reason to create things with more permissions than we need.

Comment 1

[Nathan Froyd [:froydnj]]

+1

Comment 2

[Alex Gaynor [:Alex_Gaynor]]

Attachment: Bug 1434911 - when creating temporary files, don't set the executable bit;

Review commit: https://reviewboard.mozilla.org/r/217158/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/217158/

Comment 3

[Nathan Froyd [:froydnj]]

Comment on attachment 8947461 [details]
Bug 1434911 - when creating temporary files, don't set the executable bit;

https://reviewboard.mozilla.org/r/217158/#review222962

Do we know whether our download code uses temporary files and if it sets the executable bit correctly when it renames downloaded files?  (i.e. This change is not going to break some subtle logic in the download code?)  I assume that it does, but I guess I've never checked...

Comment 4

[Alex Gaynor [:Alex_Gaynor]]

Comment on attachment 8947461 [details]
Bug 1434911 - when creating temporary files, don't set the executable bit;

https://reviewboard.mozilla.org/r/217158/#review222962

A review of all the callers in searchfox doesn't show any that look like they're related to downloading. I also kicked off a try run and won't land until that's green.

Comment 5

[Nathan Froyd [:froydnj]]

Comment on attachment 8947461 [details]
Bug 1434911 - when creating temporary files, don't set the executable bit;

https://reviewboard.mozilla.org/r/217158/#review222962

Excellent, thank you!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3308206a8cbb
when creating temporary files, don't set the executable bit; r=froydnj

Comment 7

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/3308206a8cbb