make FetchEvent.clientId non-nullable

RESOLVED FIXED in Firefox 63

Status

()

enhancement
P2
normal
RESOLVED FIXED
a year ago
8 months ago

People

(Reporter: bkelly, Assigned: perry)

Tracking

(Blocks 1 bug)

unspecified
mozilla63
Points:
---

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(1 attachment)

The spec currently defines FetchEvent.clientId as non-nullable.  We still have the old nullable version.  I had planned to wait to implement this in bug 1264177, but some WPT tests have changed to expect this.  Some discussion here:

https://github.com/w3c/ServiceWorker/issues/1266

Also, chrome has implemented and is planning to ship in chrome 66:

https://www.chromestatus.com/feature/5942197618737152
Priority: -- → P2
(Assignee)

Updated

9 months ago
Assignee: nobody → pjiang
Status: NEW → ASSIGNED
(Assignee)

Comment 1

9 months ago
Make FetchEvent.clientId non-nullable
Comment on attachment 8997940 [details]
Make FetchEvent.clientId non-nullable

Blake Kaplan (:mrbkap) has approved the revision.

https://phabricator.services.mozilla.com/D2789
Attachment #8997940 - Flags: review+

Comment 4

8 months ago
Pushed by bugmail@asutherland.org:
https://hg.mozilla.org/integration/autoland/rev/73847b793895
Make FetchEvent.clientId non-nullable r=mrbkap

Comment 5

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/73847b793895
Status: ASSIGNED → RESOLVED
Last Resolved: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.