Closed Bug 1434922 Opened 6 years ago Closed 6 years ago

Incorrect favicon in private tab

Categories

(Firefox :: Tabbed Browser, defect)

Product:
Firefox
Component:
Tabbed Browser
Version:
60 Branch
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 60
Tracking Flags:
Tracking Status
firefox-esr52 --- unaffected
firefox58 --- unaffected
firefox59 --- verified
firefox60 --- verified

People

(Reporter: winson.wen1, Assigned: johannh)

References

Details

(Keywords: regression)

Attachments

(2 files)

Untitled.jpg
30.91 KB, image/jpeg
Details
Bug 1434922 - Set a favicon for about:privatebrowsing.
59 bytes, text/x-review-board-request
florian
: review+
RyanVM
: approval-mozilla-beta+
Details
Attached image Untitled.jpg — 
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0
Build ID: 20180201100326

Steps to reproduce:

1. Open a private window
2. Navigate to any page with a favicon
3. Go back to the default private new tab page


Actual results:

Favicon on tab is stuck on the page navigated to in step 2


Expected results:

Correctly shows the private browsing mask favicon
Severity: normal → minor
Status: UNCONFIRMED → NEW
Has STR: --- → yes
Component: Untriaged → Private Browsing
Ever confirmed: true
This is a regression; I just tried a build from Dec 12 and the problem did not appear there.
Keywords: regression, regressionwindow-wanted
I'm running mozregression right now, but my money is on the change in tabbrowser.xml in https://hg.mozilla.org/mozilla-central/rev/a618b142d9dc from bug 1422903.
I suggest we mark this P5 or at most P3? It's a regression, but I don't see how it could compromise any of the design goals of private browsing.
Given that bug 1422903 is that range, I'm going to go out on a limb here.
Blocks: 1422903
Component: Private Browsing → Tabbed Browser
Ah, we just forgot to set the favicon for that page in bug 1423256. Thanks for catching this!
Assignee: nobody → jhofmann
Status: NEW → ASSIGNED
Comment on attachment 8948231 [details]
Bug 1434922 - Set a favicon for about:privatebrowsing.

https://reviewboard.mozilla.org/r/217748/#review223494

::: browser/components/privatebrowsing/content/aboutPrivateBrowsing.xhtml:22
(Diff revision 2)
>    %aboutPrivateBrowsingDTD;
>  ]>
>  
>  <html xmlns="http://www.w3.org/1999/xhtml" class="private">
>    <head>
> -    <link id="favicon" rel="icon" type="image/png"/>
> +    <link id="favicon" rel="icon" type="image/png" href="chrome://browser/skin/privatebrowsing/favicon.svg" />

nit: no space before '/>'.
Attachment #8948231 - Flags: review?(florian) → review+
Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5f1885038387
Set a favicon for about:privatebrowsing. r=florian
https://hg.mozilla.org/mozilla-central/rev/5f1885038387
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox60: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Please request uplift to beta when you get a chance.
Flags: needinfo?(jhofmann)
Comment on attachment 8948231 [details]
Bug 1434922 - Set a favicon for about:privatebrowsing.

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1422903
[User impact if declined]: Nonexistent or wrong favicon when navigating back and forth on about:privatebrowsing
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: It works on Nightly for me
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: It's one line of HTML, adding back the favicon
[String changes made/needed]: None
Flags: needinfo?(jhofmann)
Attachment #8948231 - Flags: approval-mozilla-beta?
Comment on attachment 8948231 [details]
Bug 1434922 - Set a favicon for about:privatebrowsing.

One-line fix, taking for 59b8. Let's get QE to verify it too.
Attachment #8948231 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: qe-verify+
I have managed to reproduce the issue described in comment 0 using Firefox 60.0a1 (BuildId:20180201220225).

This issue is verified fixed using Firefox 60.0a1 (BuildId:20180208103049) on Windows 10 64bit, macOS 10.12.6 and Ubuntu 14.04 64bit.

Leaving a ni on myself just for a reminder to verify this in 59b8.
Status: RESOLVED → VERIFIED
status-firefox60: fixed → verified
Flags: needinfo?(emil.ghitta)
This issue is verified fixed using Firefox 59.0b8 (BuildId:20180208193705) on Windows 10 64bit, macOS 10.11.6 and Ubuntu 16.04 64bit.
status-firefox59: fixed → verified
Flags: qe-verify+
Flags: needinfo?(emil.ghitta)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: