1434925 - Crash in java.lang.IllegalArgumentException: width and height must be > 0 at android.graphics.Bitmap.createBitmap(Bitmap.java)

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Android, defect)

Description

[Marcia Knous [:marcia]]

This bug was filed from the Socorro interface and is
report bp-f9be70f7-2836-46f3-8b7e-62c9b0180201.
=============================================================

Seen while looking at release crash stats, but also present on other branches: http://bit.ly/2DSG7rw. In 58.0.1 this is the #11 overall browser crash. Almost 70% of those crashing crashed in under a minute. APIs from 16-27 are affected, and there is a wide spectrum of devices.

Comments
* Loading Firefox from external link (new tab) 
* just pasted and goed a link to a post on space battles. Started scrolling down and a brief freeze before crashing 
* I was just browsing Stack Overflow when it happened with some other tabs opened. 

Top 10 frames of crashing thread:

0 libxul.so mozilla::jni::Accessor::EndAccess<mozilla::java::AndroidGamepadManager::OnGamepadAdded_t> 
1 libxul.so mozilla::jni::Method<mozilla::java::LayerView::Compositor::RecvToolbarAnimatorMessage_t, void>::Call<int> widget/android/jni/Accessors.h:99
2 libxul.so mozilla::java::LayerView::Compositor::RecvToolbarAnimatorMessage widget/android/GeneratedJNIWrappers.cpp:1340
3 libxul.so nsWindow::LayerViewSupport::RecvToolbarAnimatorMessage widget/android/nsWindow.cpp:1095
4 libxul.so nsWindow::RecvToolbarAnimatorMessageFromCompositor widget/android/nsWindow.cpp:2353
5 libxul.so mozilla::layers::UiCompositorControllerChild::RecvToolbarAnimatorMessageFromCompositor gfx/layers/ipc/UiCompositorControllerChild.cpp:270
6 libxul.so mozilla::layers::PUiCompositorControllerChild::OnMessageReceived ipc/ipdl/PUiCompositorControllerChild.cpp:379
7 libxul.so mozilla::ipc::MessageChannel::DispatchAsyncMessage ipc/glue/MessageChannel.cpp:2119
8 libxul.so mozilla::ipc::MessageChannel::DispatchMessage ipc/glue/MessageChannel.cpp:2049
9 libxul.so mozilla::ipc::MessageChannel::AssertWorkerThread ipc/glue/MessageChannel.h:530

=============================================================

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Jim, is this something you can take a look at?

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Sure. Looks like a simple fix.

Comment 3

[Mike Taylor [:miketaylr]]

wontfix for 58 giving timing. but maybe we should track for 59? pretty high volume.

Comment 4

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Bug 1434925 - Skip drawing hidden toolbar elements;

Apparently a toolbar element can be zero-sized when we try to draw it to
the bitmap. We should just skip drawing in that case.

Review commit: https://reviewboard.mozilla.org/r/218798/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/218798/

Comment 5

[Randall Barker [:rbarker]]

Comment on attachment 8949482 [details]
Bug 1434925 - Skip drawing hidden toolbar elements;

https://reviewboard.mozilla.org/r/218798/#review224584

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/032ad85ded1f
Skip drawing hidden toolbar elements; r=rbarker

Comment 7

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/032ad85ded1f

Comment 8

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8949482 [details]
Bug 1434925 - Skip drawing hidden toolbar elements;

Approval Request Comment
[Feature/Bug causing the regression]: n/a
[User impact if declined]: rare crash when using Fennec
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: simple fix to avoid crash
[String changes made/needed]: none

Comment 9

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8949482 [details]
Bug 1434925 - Skip drawing hidden toolbar elements;

Fairly low volume crash, but since the fix is verified in nightly, let's uplift for beta 11.

Comment 10

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/releases/mozilla-beta/rev/70cc9d6d659f