Fix error handling in nsMsgCompose::BodyConvertible(), nsMsgCompose::_NodeTreeConvertible() and nsMsgCompose::TagConvertible()

RESOLVED FIXED in Thunderbird 60.0

Status

enhancement
RESOLVED FIXED
Last year
Last year

People

(Reporter: jorgk, Assigned: jorgk)

Tracking

Trunk
Thunderbird 60.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Assignee

Description

Last year
Follow up from bug 1434515 comment #27.
Assignee

Updated

Last year
Version: 52 → Trunk
Assignee

Comment 1

Last year
Assignee: nobody → jorgk
Status: NEW → ASSIGNED
Attachment #8947538 - Flags: review?(acelists)

Comment 2

Last year
Comment on attachment 8947538 [details] [diff] [review]
1434972-convertible-handling.patch (v1)

Review of attachment 8947538 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, looks OK, if we have no use for the function return value (no cases different from NS_OK if you check the root element outside of the function).

::: mailnews/compose/src/nsMsgCompose.cpp
@@ +5340,5 @@
>    *result = nsIMsgCompSendFormat::AskUser;
>    return NS_OK;
>  }
>  
> +/*

I think there uses to be ** at the start of comment block.

@@ +5539,4 @@
>      int32_t result;
>  
>      // Check this node
> +     TagConvertible(node, &result);

Bad indent?
Attachment #8947538 - Flags: review?(acelists) → review+

Comment 3

Last year
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/de00262fbce6
fix error handling in nsMsgCompose::BodyConvertible(), nsMsgCompose::_NodeTreeConvertible() and nsMsgCompose::TagConvertible(). r=aceman DONTBUILD
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Assignee

Comment 4

Last year
Thanks for the quick review.

Landed with the ** at the start of the comment block. The entire three functions are incorrectly indented. I fixed one of them now to avoid too much noise.
Target Milestone: --- → Thunderbird 60.0
You need to log in before you can comment on or make changes to this bug.