Closed
Bug 1434976
Opened 6 years ago
Closed 6 years ago
Stop setting web-extension install prompt message details dynamically
Categories
(WebExtensions :: Frontend, enhancement, P3)
WebExtensions
Frontend
Tracking
(firefox60 verified)
VERIFIED
FIXED
mozilla60
Tracking | Status | |
---|---|---|
firefox60 | --- | verified |
People
(Reporter: prathiksha, Assigned: prathiksha)
Details
Attachments
(3 files)
In ExtensionsUI.jsm(https://searchfox.org/mozilla-central/source/browser/modules/ExtensionsUI.jsm), notification prompt text is set using innerHTML in a few places. This bug is used to track the removal of these occurrences and to use alternative ways to set the text in webextension prompts.
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → prathikshaprasadsuman
Status: NEW → ASSIGNED
Updated•6 years ago
|
Priority: -- → P3
Assignee | ||
Updated•6 years ago
|
Summary: Clean up innerHTML code in ExtensionsUI.jsm → Stop setting web-extension install prompt message details dynamically
Comment hidden (mozreview-request) |
Comment 2•6 years ago
|
||
mozreview-review |
Comment on attachment 8951230 [details] Bug 1434976 - Stop setting web-extension install prompt message details dynamically. https://reviewboard.mozilla.org/r/220496/#review226536 r=me but note the comments below Thanks! ::: browser/locales/en-US/chrome/browser/browser.dtd:997 (Diff revision 1) > display a tooltip for accessibility indicator in toolbar/tabbar. It is also > used as a textual label for the indicator used by assistive technology > users. --> > <!ENTITY accessibilityIndicator.tooltip "Accessibility Features Enabled"> > + > +<!ENTITY addonPostInstallMessage.label "Manage your add-ons by clicking <image id='addon-addon-icon'/> in the <image id='addon-toolbar-icon'/> menu."> Please add a note not to translate the <image> tags. ::: browser/themes/linux/browser.css:279 (Diff revision 1) > display: inline; > font-weight: bold; > margin: 0; > } > > -.addon-addon-icon, > +#addon-addon-icon, Is there any specific reason why these need to be ids now? If not, why are you making this change?
Attachment #8951230 -
Flags: review?(jhofmann) → review+
Assignee | ||
Comment 3•6 years ago
|
||
mozreview-review-reply |
Comment on attachment 8951230 [details] Bug 1434976 - Stop setting web-extension install prompt message details dynamically. https://reviewboard.mozilla.org/r/220496/#review226536 > Is there any specific reason why these need to be ids now? If not, why are you making this change? No specific reason. Sorry. Reverting these changes.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by archaeopteryx@coole-files.de: https://hg.mozilla.org/integration/autoland/rev/81c5d1e20e9a Stop setting web-extension install prompt message details dynamically. r=johannh
Keywords: checkin-needed
Comment 9•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/81c5d1e20e9a
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Comment 10•6 years ago
|
||
Is manual testing required on this bug? If Yes, please provide some STR and the proper webextension(if required), if No set the “qe-verify-“ flag.
Flags: needinfo?(prathikshaprasadsuman)
Assignee | ||
Comment 11•6 years ago
|
||
Assignee | ||
Comment 12•6 years ago
|
||
STR - Open nightly and add any extension by clicking on "Add to Firefox" on addons.mozilla.org (e.g. https://addons.mozilla.org/en-US/firefox/addon/nightly-tester-tools/) - Select "Add" in the web extension install request prompt. - After install, verify the addon-installed prompt(See attachment). Thanks :)
Flags: needinfo?(prathikshaprasadsuman) → qe-verify+
Comment 13•6 years ago
|
||
This issue is verified as fixed on Firefox 60.0a1 (20180228100110) under Windows 10 64-bit and Mac OS X 10.13.2.
Updated•6 years ago
|
Status: RESOLVED → VERIFIED
Updated•6 years ago
|
Product: Toolkit → WebExtensions
You need to log in
before you can comment on or make changes to this bug.
Description
•