Closed
Bug 1435022
Opened 6 years ago
Closed 6 years ago
Clean up the CompositorVsyncScheduler code
Categories
(Core :: Graphics: Layers, enhancement)
Core
Graphics: Layers
Tracking
()
RESOLVED
FIXED
mozilla60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: kats, Assigned: kats)
Details
Attachments
(12 files)
|
59 bytes,
text/x-review-board-request
|
sotaro
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
sotaro
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
sotaro
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
sotaro
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
sotaro
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
sotaro
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
sotaro
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
sotaro
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
sotaro
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
sotaro
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
sotaro
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
sotaro
:
review+
|
Details |
This code makes me very sad anytime I get anywhere near it. Mostly because the functions all sound the same, it's not obvious from the names what calls what, and it's hard to hold in my head. It's causing me grief now with WR mochitest stuff so I'm going to clean it up. (I already have patches, but need to make sure they didn't break anything).
|
Assignee | |
Comment 1•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ebaab3a33381572e615e928ec930eb7395f74a0b Looking good so far
|
|
Assignee | |
Comment 2•6 years ago
|
||
Sorry in advance for the giant patchset but each patch is pretty small and basically standalone so hopefully it should be easy to review.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 15•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8947622 [details] Bug 1435022 - Inline OnForceComposeToTarget and clarify the comment. https://reviewboard.mozilla.org/r/217318/#review223252
Attachment #8947622 -
Flags: review?(sotaro.ikeda.g) → review+
|
|
||
Comment 16•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8947623 [details] Bug 1435022 - Make ScheduleTask private and drop a useless argument. https://reviewboard.mozilla.org/r/217320/#review223254
Attachment #8947623 -
Flags: review?(sotaro.ikeda.g) → review+
|
|
||
Comment 17•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8947624 [details] Bug 1435022 - Remove the ResumeComposition function from the vsync scheduler. https://reviewboard.mozilla.org/r/217322/#review223256
Attachment #8947624 -
Flags: review?(sotaro.ikeda.g) → review+
|
|
||
Comment 18•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8947625 [details] Bug 1435022 - Inline a one-line function with a confusing name. https://reviewboard.mozilla.org/r/217324/#review223258
Attachment #8947625 -
Flags: review?(sotaro.ikeda.g) → review+
|
|
||
Comment 19•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8947626 [details] Bug 1435022 - Make a couple of functions private. https://reviewboard.mozilla.org/r/217326/#review223260
Attachment #8947626 -
Flags: review?(sotaro.ikeda.g) → review+
|
|
||
Comment 20•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8947627 [details] Bug 1435022 - Minor cleanup on the Destroy function. https://reviewboard.mozilla.org/r/217328/#review223262
Attachment #8947627 -
Flags: review?(sotaro.ikeda.g) → review+
|
|
||
Comment 21•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8947629 [details] Bug 1435022 - Make the Composite function private and document/clean it. https://reviewboard.mozilla.org/r/217332/#review223264
Attachment #8947629 -
Flags: review?(sotaro.ikeda.g) → review+
|
|
||
Comment 22•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8947630 [details] Bug 1435022 - Document some methods. https://reviewboard.mozilla.org/r/217334/#review223266
Attachment #8947630 -
Flags: review?(sotaro.ikeda.g) → review+
|
|
||
Comment 23•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8947631 [details] Bug 1435022 - Clean up GetLastComposeTime. https://reviewboard.mozilla.org/r/217336/#review223268
Attachment #8947631 -
Flags: review?(sotaro.ikeda.g) → review+
|
|
||
Comment 24•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8947632 [details] Bug 1435022 - Remove useless code (mExpectedComposeStartTime is never assigned). https://reviewboard.mozilla.org/r/217338/#review223270
Attachment #8947632 -
Flags: review?(sotaro.ikeda.g) → review+
|
|
||
Comment 25•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8947633 [details] Bug 1435022 - Remove more unused stuff. https://reviewboard.mozilla.org/r/217340/#review223272
Attachment #8947633 -
Flags: review?(sotaro.ikeda.g) → review+
|
|
||
Comment 26•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8947628 [details] Bug 1435022 - Inline the SetNeedsComposite function. https://reviewboard.mozilla.org/r/217330/#review223276
Attachment #8947628 -
Flags: review?(sotaro.ikeda.g) → review+
|
||
Comment 27•6 years ago
|
||
Pushed by kgupta@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b3e3d4a0fd58 Inline OnForceComposeToTarget and clarify the comment. r=sotaro https://hg.mozilla.org/integration/autoland/rev/20a81a819636 Make ScheduleTask private and drop a useless argument. r=sotaro https://hg.mozilla.org/integration/autoland/rev/f91eebe2f252 Remove the ResumeComposition function from the vsync scheduler. r=sotaro https://hg.mozilla.org/integration/autoland/rev/e7f0a181d2eb Inline a one-line function with a confusing name. r=sotaro https://hg.mozilla.org/integration/autoland/rev/d5aa68597329 Make a couple of functions private. r=sotaro https://hg.mozilla.org/integration/autoland/rev/1010e506680a Minor cleanup on the Destroy function. r=sotaro https://hg.mozilla.org/integration/autoland/rev/89844912178c Inline the SetNeedsComposite function. r=sotaro https://hg.mozilla.org/integration/autoland/rev/5d98a33f8f3e Make the Composite function private and document/clean it. r=sotaro https://hg.mozilla.org/integration/autoland/rev/5c9f4191c07b Document some methods. r=sotaro https://hg.mozilla.org/integration/autoland/rev/956046e5d39f Clean up GetLastComposeTime. r=sotaro https://hg.mozilla.org/integration/autoland/rev/18ed51506372 Remove useless code (mExpectedComposeStartTime is never assigned). r=sotaro https://hg.mozilla.org/integration/autoland/rev/18f9c8f22beb Remove more unused stuff. r=sotaro
|
||
Comment 28•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/b3e3d4a0fd58 https://hg.mozilla.org/mozilla-central/rev/20a81a819636 https://hg.mozilla.org/mozilla-central/rev/f91eebe2f252 https://hg.mozilla.org/mozilla-central/rev/e7f0a181d2eb https://hg.mozilla.org/mozilla-central/rev/d5aa68597329 https://hg.mozilla.org/mozilla-central/rev/1010e506680a https://hg.mozilla.org/mozilla-central/rev/89844912178c https://hg.mozilla.org/mozilla-central/rev/5d98a33f8f3e https://hg.mozilla.org/mozilla-central/rev/5c9f4191c07b https://hg.mozilla.org/mozilla-central/rev/956046e5d39f https://hg.mozilla.org/mozilla-central/rev/18ed51506372 https://hg.mozilla.org/mozilla-central/rev/18f9c8f22beb
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•