1435105 - Vary the payment request address label according to the `shippingType`

Status: RESOLVED FIXED

(Firefox :: WebPayments UI, enhancement, P1)

Description

[Matthew N. [:MattN]]

In the summary and shipping address add/edit pages, vary the address label according to the shippingType of the PaymentOptions:

https://w3c.github.io/payment-request/#dom-paymentshippingtype

This data is in `state.request.paymentOptions.shippingType`.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1435105 - Vary the payment request address label according to 'shippingType'.

Review commit: https://reviewboard.mozilla.org/r/222640/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/222640/

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1435105 - Rename 'shippingRequested' class to 'shipping-related' to make the name clearer as well as follow file conventions.

Review commit: https://reviewboard.mozilla.org/r/222642/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/222642/

Comment 3

[Matthew N. [:MattN]]

Comment on attachment 8953348 [details]
Bug 1435105 - Rename 'shippingRequested' class to 'shipping-related' to make the name clearer as well as follow file conventions.

https://reviewboard.mozilla.org/r/222642/#review228508

Thanks

Comment 4

[Matthew N. [:MattN]]

Comment on attachment 8953347 [details]
Bug 1435105 - Vary the payment request address label according to 'shippingType'.

https://reviewboard.mozilla.org/r/222640/#review228510

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cc27f2074495
Vary the payment request address label according to 'shippingType'. r=mattn
https://hg.mozilla.org/integration/mozilla-inbound/rev/7ab2c2f8a711
Rename 'shippingRequested' class to 'shipping-related' to make the name clearer as well as follow file conventions. r=mattn

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/cc27f2074495
https://hg.mozilla.org/mozilla-central/rev/7ab2c2f8a711