Closed Bug 1435105 Opened 6 years ago Closed 6 years ago

Vary the payment request address label according to the `shippingType`

Categories

(Firefox :: WebPayments UI, enhancement, P1)

Product:
Firefox
Component:
WebPayments UI
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 60
Tracking Flags:
Tracking Status
firefox60 --- fixed

People

(Reporter: MattN, Assigned: jaws)

References

(
URL
)

Details

(Whiteboard: [webpayments])

Attachments

(2 files)

Bug 1435105 - Vary the payment request address label according to 'shippingType'.
59 bytes, text/x-review-board-request
MattN
: review+
Details
Bug 1435105 - Rename 'shippingRequested' class to 'shipping-related' to make the name clearer as well as follow file conventions.
59 bytes, text/x-review-board-request
MattN
: review+
Details 
In the summary and shipping address add/edit pages, vary the address label according to the shippingType of the PaymentOptions:

https://w3c.github.io/payment-request/#dom-paymentshippingtype

This data is in `state.request.paymentOptions.shippingType`.
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Comment on attachment 8953348 [details]
Bug 1435105 - Rename 'shippingRequested' class to 'shipping-related' to make the name clearer as well as follow file conventions.

https://reviewboard.mozilla.org/r/222642/#review228508

Thanks
Attachment #8953348 - Flags: review?(MattN+bmo) → review+
Comment on attachment 8953347 [details]
Bug 1435105 - Vary the payment request address label according to 'shippingType'.

https://reviewboard.mozilla.org/r/222640/#review228510
Attachment #8953347 - Flags: review?(MattN+bmo) → review+
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cc27f2074495
Vary the payment request address label according to 'shippingType'. r=mattn
https://hg.mozilla.org/integration/mozilla-inbound/rev/7ab2c2f8a711
Rename 'shippingRequested' class to 'shipping-related' to make the name clearer as well as follow file conventions. r=mattn
https://hg.mozilla.org/mozilla-central/rev/cc27f2074495
https://hg.mozilla.org/mozilla-central/rev/7ab2c2f8a711
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Priority: P2 → P1
Whiteboard: [webpayments]
No longer depends on: 1427954
Product: Toolkit → Firefox
Target Milestone: mozilla60 → Firefox 60
You need to log in before you can comment on or make changes to this bug.