Closed Bug 1435132 Opened 2 years ago Closed 2 years ago

Remove some COM bits from nsIStyleSheetLinkingElement

Categories

(Core :: DOM: Core & HTML, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(3 files)

No description provided.
MozReview-Commit-ID: EibysYsW1rv
Attachment #8947690 - Flags: review?(continuation)
MozReview-Commit-ID: 2maFIxR2HkS
Attachment #8947691 - Flags: review?(continuation)
MozReview-Commit-ID: K7mnYXOJOK6
Attachment #8947692 - Flags: review?(continuation)
Attachment #8947690 - Flags: review?(continuation) → review+
Comment on attachment 8947691 [details] [diff] [review]
part 2.  Make nsIStyleSheetLinkingElement::GetCharset infallible

Review of attachment 8947691 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsIStyleSheetLinkingElement.h
@@ +75,5 @@
>    virtual void SetEnableUpdates(bool aEnableUpdates) = 0;
>  
>    /**
> +   * Gets the charset that the element claims the style sheet is in.
> +   * Can return empty string to indicate that we have no charser

nit: charser -> charset
Attachment #8947691 - Flags: review?(continuation) → review+
Attachment #8947692 - Flags: review?(continuation) → review+
> nit: charser -> charset

Fixed.
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d2d16fa076a7
part 1.  Remove NS_IMETHOD noise from never-failing nsIStyleSheetLinkingElement methods.  r=mccr8
https://hg.mozilla.org/integration/mozilla-inbound/rev/b3be06248ef5
part 2.  Make nsIStyleSheetLinkingElement::GetCharset infallible.  r=mccr8
https://hg.mozilla.org/integration/mozilla-inbound/rev/965c5adb6982
part 3.  Remove the last NS_IMETHOD bit from nsIStyleSheetLinkingElement.  r=mccr8
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.