1435180 - Make existing tests aware of strict keypress event firing

Status: RESOLVED FIXED

(Core :: DOM: Events, enhancement)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

We will stop dispatching keypress event on web contents (bug 968056). But some automated tests assumes current behavior. We need to rewrite them first.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=855eba50012e5f47d7330905f56122e1ff04f6fe

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3d2e14e083e4182e84fc0cc53f993691242e1241

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0f9d29f3c451a16f30f1b949bb44d175cda16334

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1435180 - Make existing tests aware of strict keypress event dispatch

We'll stop dispatching keypress events on web contents for conforming to spec of
UI Events.  Some existing tests assumes that keypress events are fired even
when non-printable keys are pressed.

This patch makes them check the pref,
"dom.keyboardevent.keypress.dispatch_non_printable_keys_only_system_group_in_content"
and only listen to keydown event instead of keypress even if the pref is true
and expected key event is not a printable key press.

Review commit: https://reviewboard.mozilla.org/r/217490/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/217490/

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8947939 [details]
Bug 1435180 - Make existing tests aware of strict keypress event dispatch

https://reviewboard.mozilla.org/r/217490/#review223386

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b432138bab08
Make existing tests aware of strict keypress event dispatch r=smaug

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/b432138bab08