1435223 - LinuxGamepad.cpp: -Wformat-truncation warning on an snprintf

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

In file included from /root/firefox-gcc-last/obj-x86_64-pc-linux-gnu/dom/gamepad/Unified_cpp_dom_gamepad0.cpp:110:
 /root/firefox-gcc-last/dom/gamepad/linux/LinuxGamepad.cpp: In member function 'void {anonymous}::LinuxGamepadService::AddDevice(mozilla::udev_device*)':
 /root/firefox-gcc-last/dom/gamepad/linux/LinuxGamepad.cpp:137:12: error: '%s' directive output may be truncated writing up to 127 bytes into a region of size between 112 and 126 [-Werror=format-truncation=]
             "%s-%s-%s",
             ^~~~~~~~~~

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1435223 - Increase the size of idstring to avoid a warning

Review commit: https://reviewboard.mozilla.org/r/217494/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/217494/

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Another solution could be to truncate the "name" variable so that we are always until 128 bytes.
I did it the lazy way!

Comment 3

[Andrea Marchesini [:baku]]

Comment on attachment 8947772 [details]
Bug 1435223 - Increase the size of idstring to avoid a warning

https://reviewboard.mozilla.org/r/217494/#review223300

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/86e0f2c3cc2d
Increase the size of idstring to avoid a warning r=baku

Comment 5

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/86e0f2c3cc2d