Closed Bug 1435228 Opened 3 years ago Closed 3 years ago

Bogus preprocessor macro for defining KNOWS_MACHINE_STATE

Categories

(Core :: JavaScript Engine: JIT, defect)

59 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: glaubitz, Assigned: glaubitz)

Details

Attachments

(1 file, 1 obsolete file)

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20180103231032

Steps to reproduce:

The preprocessor macro in js/src/wasm/WasmSignalHandlers.cpp has a bogus if condition:

#if defined(FP_sig) && defined(SP_sig) && defined(SP_sig)
# define KNOWS_MACHINE_STATE
#endif

This should be:

#if defined(PC_sig) && defined(FP_sig) && defined(SP_sig)
# define KNOWS_MACHINE_STATE
#endif
Component: Untriaged → JavaScript Engine: JIT
Product: Firefox → Core
Attachment #8947777 - Attachment is obsolete: true
Attachment #8947777 - Flags: review?(mh+mozilla)
Attachment #8947877 - Flags: review?(bbouvier)
Comment on attachment 8947877 [details] [diff] [review]
0001-Bug-1435228-Fix-bogus-preprocessor-macro-for-definin.patch

Review of attachment 8947877 [details] [diff] [review]:
-----------------------------------------------------------------

Duh, thanks!
Attachment #8947877 - Flags: review?(bbouvier) → review+
This one will need a try build; do you have level 1 commit access? Otherwise happy to do it for you.
Flags: needinfo?(glaubitz)
Keywords: checkin-needed
(In reply to Benjamin Bouvier [:bbouvier] from comment #4)
> This one will need a try build; do you have level 1 commit access? Otherwise
> happy to do it for you.

No, unfortunately not yet. I think I'm around 20 patches now, so I'm not sure whether this is already enough to get commit 1 access ;).
Flags: needinfo?(glaubitz)
(In reply to John Paul Adrian Glaubitz from comment #5)
> No, unfortunately not yet. I think I'm around 20 patches now, so I'm not
> sure whether this is already enough to get commit 1 access ;).

Sounds more than enough :) Feel free to open a bug to get level 1 commit access and seek vouchers among people who have done reviews (I could be one of them).

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a2f902ee99c4a165063c676e0094a1923f4d66bc
Assignee: nobody → glaubitz
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/997c15a7ba08
Fix bogus preprocessor macro for defining KNOWS_MACHINE_STATE r=bbouvier
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/997c15a7ba08
Status: UNCONFIRMED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
(In reply to Benjamin Bouvier [:bbouvier] from comment #6)
> (In reply to John Paul Adrian Glaubitz from comment #5)
> > No, unfortunately not yet. I think I'm around 20 patches now, so I'm not
> > sure whether this is already enough to get commit 1 access ;).
> 
> Sounds more than enough :) Feel free to open a bug to get level 1 commit
> access and seek vouchers among people who have done reviews (I could be one
> of them).

Ok, I will do so. Do I just open a regular bug with the title or is there a procedure for that?
Ouch, sorry about that one...
(In reply to John Paul Adrian Glaubitz from comment #9)
> (In reply to Benjamin Bouvier [:bbouvier] from comment #6)
> > (In reply to John Paul Adrian Glaubitz from comment #5)
> > > No, unfortunately not yet. I think I'm around 20 patches now, so I'm not
> > > sure whether this is already enough to get commit 1 access ;).
> > 
> > Sounds more than enough :) Feel free to open a bug to get level 1 commit
> > access and seek vouchers among people who have done reviews (I could be one
> > of them).
> 
> Ok, I will do so. Do I just open a regular bug with the title or is there a
> procedure for that?

There's a procedure which is documented there: https://www.mozilla.org/en-US/about/governance/policies/commit/access-policy/
Please let me know if you have any questions!
You need to log in before you can comment on or make changes to this bug.