1435230 - 0.46 - 0.48% installer size (windows2012-32, windows2012-64) regression on push 6f0232cb2c79b23c6a21037a9de0772902853d18 (Mon Jan 22 2018)

Status: RESOLVED FIXED

(Core :: Graphics: Text, defect, P3)

Description

[Ionuț Goldan [:igoldan]]

We have detected a build metrics regression from push:

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?changeset=6f0232cb2c79b23c6a21037a9de0772902853d18

As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

  0.5%  installer size windows2012-64 pgo      61,519,605.08 -> 61,813,298.50
  0.5%  installer size windows2012-32 pgo      57,569,080.42 -> 57,835,570.83


You can find links to graphs and comparison views for each of the above tests at: https://treeherder.mozilla.org/perf.html#/alerts?id=11391

On the page above you can see an alert for each affected platform as well as a link to a graph showing the history of scores for this test. There is also a link to a treeherder page showing the jobs in a pushlog format.

To learn more about the regressing test(s), please see: https://developer.mozilla.org/en-US/docs/Mozilla/Performance/Automated_Performance_Testing_and_Sheriffing/Build_Metrics

Comment 1

[Ionuț Goldan [:igoldan]]

:RyanVM We just started to investigate even the smaller installer size regressions. I believe there's nothing really we can do about bug 1428819. Am I right?
I filed this for tracking purposes.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Yeah, pretty unlikely we'll be able to do much about it. I didn't think we even really used FreeType on Windows.

Comment 3

[Bobby Holley (:bholley)]

Jonathan, do we indeed need FreeType on Windows?

More generally, this seems like a lot of code size for a library update. Are we using all the functionality, or can we compile some of it out?

Comment 4

[Jonathan Kew [:jfkthame]]

I was a bit surprised by this at first, as in general we don't use FT on Win; but then I realized it's probably because PDFium depends on freetype.

I don't know details of that dependency, or how the build is managed. It wouldn't surprise me if there is the potential to trim it down somewhat, but it'd require some digging. (Who looks after our PDFium integration?)

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Probably nobody at the moment. PDFium was being worked on by TDC.

Comment 6

[Bobby Holley (:bholley)]

Peter, do you own this now? If not, can you work with management to figure out who should be responsible for this?

Comment 7

[Peter Van der Beken [:peterv]]

Is this only a problem on Windows nightly builds?

Seems like we build FT for SkiaPDF, and that was turned on in bug 1322540. Jonathan, what's the status of the printing integration?

Comment 8

[Jonathan Watt [:jwatt]]

(In reply to Peter Van der Beken [:peterv] from comment #7)
> Is this only a problem on Windows nightly builds?
> 
> Seems like we build FT for SkiaPDF, and that was turned on in bug 1322540.
> Jonathan, what's the status of the printing integration?

If it's only SkiaPDF that pulls in the FT dependency, then yes, FT should only affect the size of Nightly builds. The only place we default to building SkiaPDF is for Nightly in toolkit/moz.configure here:

https://dxr.mozilla.org/mozilla-central/rev/a6f5fb18e6bcc9bffe4a0209a22d8a25510936be/toolkit/moz.configure#978

None of our mozconfig files specify --enable-skia-pdf so this shouldn't be affecting Beta or Release.

Regarding the status of printing, pdfium has been shelved so I don't think there's any reason for us to build SkiaPDF on Windows.

Comment 9

[Jonathan Watt [:jwatt]]

Attachment: patch - don't build SkiaPDF for Windows Nightly

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c2dafc93af5e
Don't build SkiaPDF for Windows Nightly. r=glandium

Comment 11

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/c2dafc93af5e

Comment 12

[Ionuț Goldan [:igoldan]]

Big installer size reduction on Nightly:

== Change summary for alert #12244 (as of Mon, 19 Mar 2018 07:29:51 GMT) ==

Improvements:

  4%  installer size windows2012-64 pgo      63,300,324.04 -> 60,787,776.50

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=12244

Comment 13

[Ryan VanderMeulen [:RyanVM]]

I don't think we need this on Beta because we were only building it on Nightly to begin with, but feel free to correct me and request uplift if that's wrong.