1435262 - MediaBlockCacheBase.h: type qualifiers ignored on cast result type [-Wignored-qualifiers]

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[Sylvestre Ledru [:Sylvestre]]

In file included from /root/firefox-gcc-last/dom/media/FileBlockCache.h:16,
                  from /root/firefox-gcc-last/dom/media/FileBlockCache.cpp:7,
                  from /root/firefox-gcc-last/obj-x86_64-pc-linux-gnu/dom/media/Unified_cpp_dom_media3.cpp:38:
 /root/firefox-gcc-last/dom/media/MediaBlockCacheBase.h: At global scope:
 /root/firefox-gcc-last/dom/media/MediaBlockCacheBase.h:43:68: error: type qualifiers ignored on cast result type [-Werror=ignored-qualifiers]
        static_cast<decltype(MediaCacheStream::BLOCK_SIZE)>(INT32_MAX),
                                                                     ^
Thanks Benjamin for the help!

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1435262 - Remove the const type qualifiers to silent a gcc 8 warning

Review commit: https://reviewboard.mozilla.org/r/217520/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/217520/

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8947826 [details]
Bug 1435262 - Remove the const type qualifiers to silent a gcc 8 warning

https://reviewboard.mozilla.org/r/217520/#review223450

Thank you for the fix.

LGTM as-is, but here's an optional nit:

::: dom/media/MediaBlockCacheBase.h:43
(Diff revision 1)
>  public:
>    NS_INLINE_DECL_THREADSAFE_REFCOUNTING(MediaBlockCacheBase)
>  
>    static_assert(
>      MediaCacheStream::BLOCK_SIZE <
> -      static_cast<decltype(MediaCacheStream::BLOCK_SIZE)>(INT32_MAX),
> +      static_cast<std::remove_cv<decltype(MediaCacheStream::BLOCK_SIZE)>::type>(INT32_MAX),

remove_const would suffice here.

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8947826 [details]
Bug 1435262 - Remove the const type qualifiers to silent a gcc 8 warning

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/217520/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6873d1a8a2ad
Remove the const type qualifiers to silent a gcc 8 warning r=gerald

Comment 5

[Mozilla Autoland]

We're sorry - something has gone wrong while rewriting or rebasing your commits. The commits being pushed no longer match what was requested. Please file a bug.

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8947826 [details]
Bug 1435262 - Remove the const type qualifiers to silent a gcc 8 warning

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/217520/diff/2-3/

Comment 7

[Mozilla Autoland]

We're sorry - something has gone wrong while rewriting or rebasing your commits. The commits being pushed no longer match what was requested. Please file a bug.

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8947826 [details]
Bug 1435262 - Remove the const type qualifiers to silent a gcc 8 warning

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/217520/diff/3-4/

Comment 9

[Mozilla Autoland]

We're sorry - something has gone wrong while rewriting or rebasing your commits. The commits being pushed no longer match what was requested. Please file a bug.

Comment 10

[Sylvestre Ledru [:Sylvestre]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/eb87c9467a3598f9cf9fddfcb31fdcc42fc79241
Bug 1435262 - Remove the const type qualifiers to silent a gcc 8 warning r=gerald

Comment 11

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/6873d1a8a2ad

Comment 12

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/eb87c9467a35

Comment 13

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8947826 [details]
Bug 1435262 - Remove the const type qualifiers to silent a gcc 8 warning

Thanks for the patch; sorry for the delay on the review, looks like you got it landed anyway.