Closed
Bug 1435285
Opened 6 years ago
Closed 6 years ago
Compile failure due to forward-declaration of an enum in ServoBindings.h
Categories
(Core :: CSS Parsing and Computation, enhancement)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: jfkthame, Assigned: jfkthame)
Details
Attachments
(1 file)
It's not valid to forward-declare an enum without an explicit base type, as the compiler can't tell how big it is. Fortunately, we don't need to forward-declare mozilla::Side in ServoBindings.h anyhow, because mozilla/gfx/Types.h which declares it is (indirectly) included anyhow.
|
Assignee | |
Comment 1•6 years ago
|
||
Attachment #8947878 -
Flags: review?(emilio)
|
||
Comment 2•6 years ago
|
||
Comment on attachment 8947878 [details] [diff] [review] Remove invalid fwd-declaration of enum without explicit base type; while we're here, also remove an obsolete comment Review of attachment 8947878 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #8947878 -
Flags: review?(emilio) → review+
Pushed by jkew@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/e22e42b82d6c Remove invalid fwd-declaration of enum without explicit base type; while we're here, also remove an obsolete comment. r=emilio
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/e22e42b82d6c
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•