csscoverage report is broken / Chart.PieTable without a specified header fails

VERIFIED FIXED in Firefox 59

Status

VERIFIED FIXED
a year ago
9 months ago

People

(Reporter: Kwan, Assigned: Kwan)

Tracking

Trunk
Firefox 60

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox58 wontfix, firefox59 verified, firefox60 verified)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
STR:
0) open a webpage, e.g. https://www.mozilla.org/
1) open the Style Editor (Shift+F7)
2) open the GCLI/"Developer Toolbar" (Shift+F2)
3) run csscoverage start
4) run csscoverage stop
5) run csscoverage report

AR:
nothing, "TypeError: can't convert undefined to object" causing an unhandled promise rejection chain in the browser console

ER:
a coverage report appears, with a chart, list of unused rules etc.

This was broken by bug 1168376 which added the header field, but didn't give it a default empty object like strings and totals get, so it throws "TypeError: can't convert undefined to object" when it tries to call Object.entries on the header.
Comment hidden (mozreview-request)
Comment on attachment 8947918 [details]
Bug 1435320 - Specify a default empty object for the Chart.js table header.

https://reviewboard.mozilla.org/r/217594/#review223586

Great catch, thanks for the patch!

R+ assuming try is green

Honza
Attachment #8947918 - Flags: review?(odvarko) → review+

Comment 4

a year ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/353a5c7a0bb3
Specify a default empty object for the Chart.js table header. r=Honza
Keywords: checkin-needed

Comment 5

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/353a5c7a0bb3
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox60: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
status-firefox58: affected → wontfix
Please request uplift if you think we should get this in beta59.
Flags: needinfo?(moz-ian)
Comment on attachment 8947918 [details]
Bug 1435320 - Specify a default empty object for the Chart.js table header.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1168376
[User impact if declined]: CSS code coverage tool doesn't work properly
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: n/a
[Is the change risky?]: low risk
[Why is the change risky/not risky?]: Only for dev folks + very small change.
[String changes made/needed]: n/a
Attachment #8947918 - Flags: approval-mozilla-beta?
Comment on attachment 8947918 [details]
Bug 1435320 - Specify a default empty object for the Chart.js table header.

Minor fix for dev tools recent regression, let's bring it to 59 beta 10.
Attachment #8947918 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Comment 9

a year ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/47d05846b2c1
status-firefox59: affected → fixed
I have reproduced this bug with nightly 60.0a1 (2018-02-02) (64-bit) on Windows 10, 64 Bit!

This bug's fix is verified with latest Beta and latest Nightly!

Build ID   : 20180215111455
User Agent : Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:59.0) Gecko/20100101 Firefox/59.0  

Build ID   : 20180218220057
User Agent : Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0
QA Whiteboard: [bugday-20180214]
status-firefox60: fixed → verified
(In reply to Mohammad Maruf Rahman from comment #10)
> I have reproduced this bug with nightly 60.0a1 (2018-02-02) (64-bit) on
> Windows 10, 64 Bit!
> 
> This bug's fix is verified with latest Beta and latest Nightly!
> 
> Build ID   : 20180215111455
> User Agent : Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:59.0)
> Gecko/20100101 Firefox/59.0  
> 
> Build ID   : 20180218220057
> User Agent : Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:60.0)
> Gecko/20100101 Firefox/60.0

Ups, I missed the fact that you also verified on 59.0. Thanks for that! Marking as verified fixed.
Status: RESOLVED → VERIFIED
status-firefox59: fixed → verified

Updated

a year ago
Flags: needinfo?(moz-ian)

Updated

9 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.