1435345 - Searchfox can't find uses of operator==

Status: RESOLVED FIXED

(Webtools :: Searchfox, enhancement)

Description

[Ryan Hunt [:rhunt]]

This might be more general to all types of operator, but I have seen it for sure with operator==.

For example clicking on gfx::Matrix::operator== and searching for uses will show no results, but there definitely are uses of it. [1]

[1] https://searchfox.org/mozilla-central/rev/eeb7190f9ad6f1a846cd6df09986325b3f2c3117/gfx/2d/Matrix.h#323

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Apparently we bail out on generating use-site analysis for operators at [1]. Not really clear to me which consumers would trip up on this. I'll try removing it and seeing what happens.

[1] https://searchfox.org/mozilla-central/source/build/clang-plugin/mozsearch-plugin/MozsearchIndexer.cpp#60

Comment 2

[Kartikaya Gupta (email:[e-mail])]

https://dev.searchfox.org/mozilla-central/search?q=symbol:_ZNK7mozilla3gfx10BaseMatrixeqERKNS0_10BaseMatrixIT_EE&redirect=false

Seems to work

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Hm, my patch was a little too liberal. It now indexes things like
  function mozilla::gfx::IntRectTyped::operator=   [1]
  function RefPtr::operator->                      [2]
  function std::operator<<                         [3]

and many other operators. Although maybe this is desirable? Any thoughts?

I'll put the patches up for now.

[1] https://dev.searchfox.org/mozilla-central/search?q=symbol%3A_ZN7mozilla3gfx12IntRectTypedINS0_12UnknownUnitsEEaSERKS3_&path=
[2] https://dev.searchfox.org/mozilla-central/search?q=symbol%3A_ZNK6RefPtrptEv&path=
[3] https://dev.searchfox.org/mozilla-central/search?q=symbol%3A_ZStlsRSt13basic_ostreamIcT_Ec&path=

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1435345 - Part 0: sync change from searchfox repo.

This change was made in the mozsearch/mozsearch repo at some point and wasn't
synced to m-c.

Review commit: https://reviewboard.mozilla.org/r/217706/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/217706/

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1435345 - Part 1: Index use sites of overloaded C++ operators.

Review commit: https://reviewboard.mozilla.org/r/217708/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/217708/

Comment 6

[Kartikaya Gupta (email:[e-mail])]

After some thought I figured all the extra operator indexing is probably fine. If it turns out to be a problem we can always undo it.

Comment 7

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 8948081 [details]
Bug 1435345 - Part 0: sync change from searchfox repo.

https://reviewboard.mozilla.org/r/217706/#review223486

Comment 8

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 8948082 [details]
Bug 1435345 - Part 1: Index use sites of overloaded C++ operators.

https://reviewboard.mozilla.org/r/217708/#review223488

Looks good, thanks!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9aced56a4405
Part 0: sync change from searchfox repo. r=emilio
https://hg.mozilla.org/integration/autoland/rev/b9fd48f0b7d7
Part 1: Index use sites of overloaded C++ operators. r=emilio

Comment 10

[Kartikaya Gupta (email:[e-mail])]

Also merged to mozsearch repo, the indexing run today should pick it up and deploy.

Comment 11

[Botond Ballo [:botond]]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #3)
> Hm, my patch was a little too liberal. It now indexes things like
>   function mozilla::gfx::IntRectTyped::operator=   [1]
>   function RefPtr::operator->                      [2]
>   function std::operator<<                         [3]
> 
> and many other operators. Although maybe this is desirable? Any thoughts?

Seems useful to me!

Comment 12

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/9aced56a4405
https://hg.mozilla.org/mozilla-central/rev/b9fd48f0b7d7

Comment 13

[Kartikaya Gupta (email:[e-mail])]

This is finally deployed after having to deal with a bunch of unrelated issues that caused searchfox indexing to fail over the weekend.