Closed Bug 1435406 Opened 2 years ago Closed 2 years ago

Remove implicit fuzzy operator== from BaseMatrix

Categories

(Core :: Graphics, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: rhunt, Assigned: rhunt)

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file)

I think better default operator== is non-fuzzy.

I'm not sure if any callers actually rely on this behavior, but there are only like three apparently, so I just moved them all to use FuzzyEquals.

I have a patch written, but I need to wait on try to make sure I didn't miss any other users of the operator==.
Should we just use =delete; for operator==, along with a comment saying that users should be more specific and request the behaviour that they want?
Yeah I think deleting the default operator's is a good way to go. Took an extra try because I locally missed some debug only checks.

This patch should have no functional changes as all preexisting uses of operator== are moved to the explicit fuzzy method.
Attachment #8948466 - Flags: review?(matt.woodrow)
Attachment #8948466 - Flags: review?(matt.woodrow) → review+
Pushed by rhunt@eqrion.net:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f72d9fdf6e97
Remove implicit fuzzy operator== from BaseMatrix (bug 1435406, r=mattwoodrow)
https://hg.mozilla.org/mozilla-central/rev/f72d9fdf6e97
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.