1435409 - build on Android with a non-NDK clang

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Nathan Froyd [:froydnj]]

The clang in the NDK works, but we would like to run static analysis on our Android code, and it's unclear whether the NDK clang supports plugins, even on an unofficial basis.  The clang headers are there, so presumably one *can* compile plugins, but it seems like a not-great idea to depend on functionality that's not explicitly supported.

Compiling with our own clang also means one less compiler to test with, which is nice for a variety of reasons.

Using a different clang is a two-line change to a mozconfig, but there are a variety of issues to sort through first.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: use our own clang rather than the NDK clang to build Android

This enables us to do things like reliably build the static analysis plugin, as
well as reducing compiler diversity a bit.

Comment 2

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8979937 [details] [diff] [review]
use our own clang rather than the NDK clang to build Android

Review of attachment 8979937 [details] [diff] [review]:
-----------------------------------------------------------------

If you're happy with it in try and tests, fine by me.  We can roll back if we see Nightly crashes.

Comment 3

[Mike Hommey [:glandium]]

Nathan, can you land this? this is going to be necessary for LTO on Android.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/de5e21062a40
use our own clang rather than the NDK clang to build Android; r=nalexander

Comment 5

[Nathan Froyd [:froydnj]]

(In reply to Mike Hommey [:glandium] from comment #3)
> Nathan, can you land this? this is going to be necessary for LTO on Android.

Done.

Comment 6

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/de5e21062a40