Closed
Bug 1435409
Opened 3 years ago
Closed 3 years ago
build on Android with a non-NDK clang
Categories
(Firefox Build System :: General, enhancement)
Tracking
(firefox60 wontfix, firefox61 wontfix, firefox62 wontfix, firefox63 fixed)
RESOLVED
FIXED
mozilla63
People
(Reporter: froydnj, Assigned: froydnj)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
1.20 KB,
patch
|
nalexander
:
review+
|
Details | Diff | Splinter Review |
The clang in the NDK works, but we would like to run static analysis on our Android code, and it's unclear whether the NDK clang supports plugins, even on an unofficial basis. The clang headers are there, so presumably one *can* compile plugins, but it seems like a not-great idea to depend on functionality that's not explicitly supported. Compiling with our own clang also means one less compiler to test with, which is nice for a variety of reasons. Using a different clang is a two-line change to a mozconfig, but there are a variety of issues to sort through first.
Updated•3 years ago
|
Product: Core → Firefox Build System
![]() |
Assignee | |
Comment 1•3 years ago
|
||
This enables us to do things like reliably build the static analysis plugin, as well as reducing compiler diversity a bit.
Attachment #8979937 -
Flags: review?(core-build-config-reviews)
![]() |
Assignee | |
Updated•3 years ago
|
Assignee: nobody → nfroyd
Comment 2•3 years ago
|
||
Comment on attachment 8979937 [details] [diff] [review] use our own clang rather than the NDK clang to build Android Review of attachment 8979937 [details] [diff] [review]: ----------------------------------------------------------------- If you're happy with it in try and tests, fine by me. We can roll back if we see Nightly crashes.
Attachment #8979937 -
Flags: review?(core-build-config-reviews) → review+
Comment 3•3 years ago
|
||
Nathan, can you land this? this is going to be necessary for LTO on Android.
Flags: needinfo?(nfroyd)
Pushed by nfroyd@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/de5e21062a40 use our own clang rather than the NDK clang to build Android; r=nalexander
![]() |
Assignee | |
Comment 5•3 years ago
|
||
(In reply to Mike Hommey [:glandium] from comment #3) > Nathan, can you land this? this is going to be necessary for LTO on Android. Done.
Flags: needinfo?(nfroyd)
Comment 6•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/de5e21062a40
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Updated•3 years ago
|
Blocks: android-lto
Updated•3 years ago
|
status-firefox61:
--- → wontfix
status-firefox62:
--- → wontfix
You need to log in
before you can comment on or make changes to this bug.
Description
•