Closed
Bug 1435423
Opened 6 years ago
Closed 6 years ago
Fold browser-charsetmenu.inc into browser-menubar.inc
Categories
(Firefox :: Menus, enhancement)
Firefox
Menus
Tracking
()
RESOLVED
FIXED
Firefox 60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: bgrins, Assigned: bgrins)
Details
Attachments
(1 file)
Right now we have a separate file browser-charsetmenu.inc that only gets included in browser-menubar.inc. This file used to be bigger but now has only a single <menu> in it and could be folded into the parent file in the interest of simplicity. - https://searchfox.org/mozilla-central/source/browser/base/content/browser-menubar.inc - https://searchfox.org/mozilla-central/source/browser/base/content/browser-charsetmenu.inc
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
| Comment hidden (mozreview-request) |
|
||
Comment 2•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8948011 [details] Bug 1435423 - Fold browser-charsetmenu.inc into browser-menubar.inc; https://reviewboard.mozilla.org/r/217654/#review223446
Attachment #8948011 -
Flags: review?(dtownsend) → review+
|
|
Assignee | |
Comment 3•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=fdbf0993463ad145489bab4e04a136d2297b0a10
Pushed by bgrinstead@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8747c9b1107a Fold browser-charsetmenu.inc into browser-menubar.inc;r=mossop
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/8747c9b1107a
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
You need to log in
before you can comment on or make changes to this bug.
Description
•