Closed
Bug 1435458
Opened 6 years ago
Closed 6 years ago
browser_parsable_script.js is going to permafail when Gecko 60 merges to Beta on 2018-03-01
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 60
| Tracking | Status | |
|---|---|---|
| firefox-esr52 | --- | unaffected |
| firefox58 | --- | unaffected |
| firefox59 | --- | unaffected |
| firefox60 | + | verified |
People
(Reporter: RyanVM, Assigned: past)
References
Details
Attachments
(1 file)
Looks like bug 1432310 touched this recently. https://treeherder.mozilla.org/logviewer.html#?job_id=160181931&repo=try TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_parsable_script.js | Script error reading jar:file:///builds/worker/workspace/build/application/firefox/browser/omni.ja!/defaults/preferences/firefox-branding.js: SyntaxError: illegal character - To reproduce locally, the patch below should suffice: https://hg.mozilla.org/try/rev/24d5afa031c0e0f0366c36f65e8797d551cc38c2
Flags: needinfo?(past)
|
Reporter | |
Comment 1•6 years ago
|
||
BTW, I did confirm that backing out bug 1432310 makes this go away.
| Comment hidden (mozreview-request) |
|
Assignee | |
Comment 3•6 years ago
|
||
Sorry about that! I could swear that it worked when I originally tested it...
Assignee: nobody → past
Status: NEW → ASSIGNED
Flags: needinfo?(past)
|
||
Comment 4•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8949934 [details] Bug 1435458 - Preprocess the official firefox-branding.js. https://reviewboard.mozilla.org/r/219240/#review225504
Attachment #8949934 -
Flags: review?(mh+mozilla) → review+
Pushed by pastithas@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a8a0ca1b2ea5 Preprocess the official firefox-branding.js. r=glandium
|
||
Comment 6•6 years ago
|
||
Backed out changeset a8a0ca1b2ea5 (bug 1435458) for failed Deleting file '../../../dist/bin/browser/defaults/preferences/firefox-branding.js on a CLOSED TREE https://hg.mozilla.org/integration/autoland/rev/f028ec193bb30ec14202e085e345dbb33e499a14 https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=f028ec193bb30ec14202e085e345dbb33e499a14&filter-classifiedState=unclassified&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 9•6 years ago
|
||
I've debated using MOZILLA_OFFICIAL instead of MOZ_OFFICIAL_BRANDING, but the latter seems more inline with the when file is being used both locally and in automation. Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8f9d0ccdbede40115573b03ab5cc07c7d80887b2
|
|
||
Comment 10•6 years ago
|
||
It would probably be better to check if MOZ_BRANDING_DIRECTORY is browser/branding/official, because MOZ_OFFICIAL_BRANDING is not always set when it is. OTOH, there are other places where MOZ_OFFICIAL_BRANDING is checked... so it would actually be better to fix configure so that MOZ_OFFICIAL_BRANDING when MOZ_BRANDING_DIRECTORY is MOZ_OFFICIAL_BRANDING_DIRECTORY.
Flags: needinfo?(mh+mozilla)
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 12•6 years ago
|
||
Both suggestions make sense. I went with the first one since, unfortunately, I don't have the time to put more work on this at the moment. Try is still happy: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7c77a33e0a23bca36db595832dffc0a5e1781a7f
|
||
Comment 13•6 years ago
|
||
Pushed by pastithas@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9688823d23fd Preprocess the official firefox-branding.js. r=glandium
|
||
Comment 14•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/9688823d23fd
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
|
||
Updated•6 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•