1435483 - Do some cleanup on our exception classes

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Boris Zbarsky [:bzbarsky]]

There's a bunch of XPCOM goop we can remove here.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: part 1. Stop using nsIXPCException in devtools code

This code has never worked correctly.  Bug 911258 landed on 2013-09-09 and
removed the initialize() method from XPConnect exceptions.  This code landed
two days after that.  If it's ever reached, it will just throw when calling the
nonexistent initialize() method.

MozReview-Commit-ID: FWpP1fLBIPW

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: part 2. Stop allowing creation of Exception objects via contract/CID

Bobby, could you review the CanCreateInstance call removal carefully?  I'm pretty sure we should be system-only there, but maybe I'm missing something?

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: part 3. Remove nsIXPCException

This interface is not usable from JS, because we don't expose initialize() in
the WebIDL bindings for Exception.  And C++ doesn't use it.

MozReview-Commit-ID: LsIm4YA0YZE

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: part 4. Remove always-true mInitialized member from Exception

MozReview-Commit-ID: H1ZPg76xNyI

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: part 5. Add an infallible "filename" getter on nsIStackFrame

MozReview-Commit-ID: D3uuehuDqOB

Comment 6

[Boris Zbarsky [:bzbarsky]]

Attachment: part 6. Add an infallible "lineNumber" getter on nsIStackFrame

MozReview-Commit-ID: 7aYg9kJhiab

Comment 7

[Boris Zbarsky [:bzbarsky]]

Attachment: part 7. Add an infallible "columnNumber" getter on nsIStackFrame

MozReview-Commit-ID: 7VJvDR0qD3G

Comment 8

[Boris Zbarsky [:bzbarsky]]

Attachment: part 8. Add an infallible "asyncCause" getter on nsIStackFrame

MozReview-Commit-ID: KpRyt21PF7W

Comment 9

[Boris Zbarsky [:bzbarsky]]

Attachment: part 9. Add an infallible "name" getter on nsIStackFrame

MozReview-Commit-ID: ADxO2A8nkel

Comment 10

[Boris Zbarsky [:bzbarsky]]

Attachment: part 10. Add infallible "asyncCaller" and "caller" getters on nsIStackFrame

MozReview-Commit-ID: 8pdMDFHWlVt

Comment 11

[Boris Zbarsky [:bzbarsky]]

Attachment: part 11. Add an infallible "formattedStack" getter on nsIStackFrame

MozReview-Commit-ID: KLSzUuWt45x

Comment 12

[Boris Zbarsky [:bzbarsky]]

Attachment: part 12. Add an infallible "toString" method on nsIStackFrame

MozReview-Commit-ID: CTCawPvw6VZ

Comment 13

[Boris Zbarsky [:bzbarsky]]

Attachment: part 13. Remove nsIException::GetName

MozReview-Commit-ID: CXnwjeHoGRm

Comment 14

[Boris Zbarsky [:bzbarsky]]

Attachment: part 14. Remove nsIException::GetFilename/GetLineNumber/GetColumnNumber

MozReview-Commit-ID: 6JN7UvkhPgl

Comment 15

[Boris Zbarsky [:bzbarsky]]

Attachment: part 15. Remove nsIDOMRequestService::FireDetailedError

It's doing casts that are bogus.  We can do the same thing (only needed for
tests anyway) via a chromeonly API on DOMRequest.

MozReview-Commit-ID: 1FUPGMhBU3k

Comment 16

[Boris Zbarsky [:bzbarsky]]

Attachment: part 16. Switch to using dom::Exception, not nsIException, in C++ code

nsIException is builtinclass in idl, so whatever code we had to handle
non-dom::Exception nsIExceptions is dead code.

MozReview-Commit-ID: 6VnqDWt0041

Comment 17

[Boris Zbarsky [:bzbarsky]]

Attachment: part 17. Remove nsIException::GetMessageMoz

MozReview-Commit-ID: GKzE812BfIF

Comment 18

[Boris Zbarsky [:bzbarsky]]

Attachment: part 18. Remove nsIException::GetResult

MozReview-Commit-ID: JArus2ddEsL

Comment 19

[Boris Zbarsky [:bzbarsky]]

Attachment: part 19. Remove nsIException::GetLocation

MozReview-Commit-ID: AbVQ7IA4xqp

Comment 20

[Boris Zbarsky [:bzbarsky]]

Attachment: part 20. Remove nsIException::GetData

MozReview-Commit-ID: 9cDzCeddOmh

Comment 21

[Boris Zbarsky [:bzbarsky]]

Attachment: part 21. Remove nsIException::ToString

MozReview-Commit-ID: 17yuhlqzbr2

Comment 22

[Boris Zbarsky [:bzbarsky]]

Attachment: Part 18 diff -w

Comment 23

[Boris Zbarsky [:bzbarsky]]

Attachment: Part 21 diff -w

Comment 24

[Boris Zbarsky [:bzbarsky]]

Attachment: part 17. Remove nsIException::GetMessageMoz

MozReview-Commit-ID: GKzE812BfIF

Comment 25

[Alexandre Poirot [:ochameau]]

Comment on attachment 8948203 [details] [diff] [review]
part 1.  Stop using nsIXPCException in devtools code

I'm not sure this code is still used, this was related to FXOS.

Comment 26

[Alexandre Poirot [:ochameau]]

(In reply to Alexandre Poirot [:ochameau] from comment #25)
> I'm not sure this code is still used, this was related to FXOS.

Created bug 1435791 to remove this code.

Comment 27

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 8948209 [details] [diff] [review]
part 7.  Add an infallible "columnNumber" getter on nsIStackFrame

Review of attachment 8948209 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bindings/Exceptions.cpp
@@ +479,5 @@
>  
>    return col;
>  }
>  
> +NS_IMETHODIMP JSStackFrame::GetColumnNumberXPCOM(JSContext* aCx,

nit: Might as well fix formatting while you're here?

Comment 28

[Boris Zbarsky [:bzbarsky]]

> nit: Might as well fix formatting while you're here?

Done.

Comment 29

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 8948223 [details] [diff] [review]
part 21.  Remove nsIException::ToString

Review of attachment 8948223 [details] [diff] [review]:
-----------------------------------------------------------------

::: xpcom/base/nsIException.idl
@@ +66,5 @@
>  };
>  
> +// This interface only exists because of all the JS consumers doing
> +// "instanceof Ci.nsIException".  We should switch them to something else and
> +// get rid of it.  C++ code should NOT use this; use mozilla::dom::Exception

nit: Do we have followup filed for this? If so, can we mention it here?

Comment 30

[Boris Zbarsky [:bzbarsky]]

> nit: Do we have followup filed for this?

Not yet, but I can file and mention: bug 1435856.

Comment 31

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/af047d35cc1f
part 1.  Stop using nsIXPCException in devtools code.  r=ochameau
https://hg.mozilla.org/integration/mozilla-inbound/rev/4798fb33e87f
part 2.  Stop allowing creation of Exception objects via contract/CID.  r=bholley
https://hg.mozilla.org/integration/mozilla-inbound/rev/432d38e26230
part 3.  Remove nsIXPCException.  r=qdot
https://hg.mozilla.org/integration/mozilla-inbound/rev/c916ed1fb22e
part 4.  Remove always-true mInitialized member from Exception.  r=qdot
https://hg.mozilla.org/integration/mozilla-inbound/rev/06e2c91ca04f
part 5.  Add an infallible "filename" getter on nsIStackFrame.  r=qdot
https://hg.mozilla.org/integration/mozilla-inbound/rev/feec23374328
part 6.  Add an infallible "lineNumber" getter on nsIStackFrame.  r=qdot
https://hg.mozilla.org/integration/mozilla-inbound/rev/5376dbad3062
part 7.  Add an infallible "columnNumber" getter on nsIStackFrame.  r=qdot
https://hg.mozilla.org/integration/mozilla-inbound/rev/2cb9916edac9
part 8.  Add an infallible "asyncCause" getter on nsIStackFrame.  r=qdot
https://hg.mozilla.org/integration/mozilla-inbound/rev/3c7e9384e092
part 9.  Add an infallible "name" getter on nsIStackFrame.  r=qdot
https://hg.mozilla.org/integration/mozilla-inbound/rev/4065bdc6d415
part 10.  Add infallible "asyncCaller" and "caller" getters on nsIStackFrame.  r=qdot
https://hg.mozilla.org/integration/mozilla-inbound/rev/233b3c3c8c4b
part 11.  Add an infallible "formattedStack" getter on nsIStackFrame.  r=qdot
https://hg.mozilla.org/integration/mozilla-inbound/rev/b7d20b7d9230
part 12.  Add an infallible "toString" method on nsIStackFrame.  r=qdot
https://hg.mozilla.org/integration/mozilla-inbound/rev/6c6988ae4688
part 13.  Remove nsIException::GetName.  r=qdot
https://hg.mozilla.org/integration/mozilla-inbound/rev/43b00825c08c
part 14.  Remove nsIException::GetFilename/GetLineNumber/GetColumnNumber.  r=qdot
https://hg.mozilla.org/integration/mozilla-inbound/rev/c8e4cf95eb66
part 15.  Remove nsIDOMRequestService::FireDetailedError.  r=qdot
https://hg.mozilla.org/integration/mozilla-inbound/rev/1cc1b9042bb3
part 16.  Switch to using dom::Exception, not nsIException, in C++ code.  r=qdot
https://hg.mozilla.org/integration/mozilla-inbound/rev/3dc0da16efed
part 17.  Remove nsIException::GetMessageMoz.  r=qdot
https://hg.mozilla.org/integration/mozilla-inbound/rev/bd57d71589c2
part 18.  Remove nsIException::GetResult.  r=qdot
https://hg.mozilla.org/integration/mozilla-inbound/rev/bbad188127c1
part 19.  Remove nsIException::GetLocation.  r=qdot
https://hg.mozilla.org/integration/mozilla-inbound/rev/a8eaa9b9c2ce
part 20.  Remove nsIException::GetData.  r=qdot
https://hg.mozilla.org/integration/mozilla-inbound/rev/aba564b1d5ec
part 21.  Remove nsIException::ToString.  r=qdot

Comment 32

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/af047d35cc1f
https://hg.mozilla.org/mozilla-central/rev/4798fb33e87f
https://hg.mozilla.org/mozilla-central/rev/432d38e26230
https://hg.mozilla.org/mozilla-central/rev/c916ed1fb22e
https://hg.mozilla.org/mozilla-central/rev/06e2c91ca04f
https://hg.mozilla.org/mozilla-central/rev/feec23374328
https://hg.mozilla.org/mozilla-central/rev/5376dbad3062
https://hg.mozilla.org/mozilla-central/rev/2cb9916edac9
https://hg.mozilla.org/mozilla-central/rev/3c7e9384e092
https://hg.mozilla.org/mozilla-central/rev/4065bdc6d415
https://hg.mozilla.org/mozilla-central/rev/233b3c3c8c4b
https://hg.mozilla.org/mozilla-central/rev/b7d20b7d9230
https://hg.mozilla.org/mozilla-central/rev/6c6988ae4688
https://hg.mozilla.org/mozilla-central/rev/43b00825c08c
https://hg.mozilla.org/mozilla-central/rev/c8e4cf95eb66
https://hg.mozilla.org/mozilla-central/rev/1cc1b9042bb3
https://hg.mozilla.org/mozilla-central/rev/3dc0da16efed
https://hg.mozilla.org/mozilla-central/rev/bd57d71589c2
https://hg.mozilla.org/mozilla-central/rev/bbad188127c1
https://hg.mozilla.org/mozilla-central/rev/a8eaa9b9c2ce
https://hg.mozilla.org/mozilla-central/rev/aba564b1d5ec