1435499 - Crash in java.lang.OutOfMemoryError: at org.mozilla.gecko.gfx.DynamicToolbarAnimator.handleToolbarAnimatorMessage(DynamicToolbarAnimator.java)

Status: RESOLVED FIXED

(GeckoView :: Toolbar, defect)

Description

[[:philipp]]

This bug was filed from the Socorro interface and is
report bp-3e4b2e2e-0594-487e-9a11-861dd0180201.
=============================================================
Java Stack Trace 	

java.lang.OutOfMemoryError
	at org.mozilla.gecko.gfx.DynamicToolbarAnimator.handleToolbarAnimatorMessage(DynamicToolbarAnimator.java:168)
	at org.mozilla.gecko.gfx.LayerSession.handleCompositorMessage(LayerSession.java:430)
	at org.mozilla.gecko.gfx.LayerSession$Compositor.recvToolbarAnimatorMessage(LayerSession.java:110)
	at org.mozilla.gecko.GeckoThread.runUiThreadCallback(Native Method)
	at org.mozilla.gecko.GeckoThread$1.run(GeckoThread.java:100)
	at android.os.Handler.handleCallback(Handler.java:733)
	at android.os.Handler.dispatchMessage(Handler.java:95)
	at android.os.Looper.loop(Looper.java:136)
	at android.app.ActivityThread.main(ActivityThread.java:5001)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:515)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:797)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:613)
	at dalvik.system.NativeStart.main(Native Method)

=============================================================

this looks like a low volume regressing crash on fennec 59 from bug 1416319.

Comment 1

[Andrew Overholt [:overholt]]

Given comment 0, I'll needinfo Jim.

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Bug 1435499 - Guard against OOM when getting toolbar pixels;

Guard against OOM errors when getting toolbar pixels, and send a failure
message back to compositor when OOM happens.

Review commit: https://reviewboard.mozilla.org/r/218790/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/218790/

Comment 3

[Randall Barker [:rbarker]]

Comment on attachment 8949471 [details]
Bug 1435499 - Guard against OOM when getting toolbar pixels;

https://reviewboard.mozilla.org/r/218790/#review224582

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ad9f6cf50e5d
Guard against OOM when getting toolbar pixels; r=rbarker

Comment 5

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/ad9f6cf50e5d

Comment 6

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8949471 [details]
Bug 1435499 - Guard against OOM when getting toolbar pixels;

Approval Request Comment
[Feature/Bug causing the regression]: n/a
[User impact if declined]: rare crash when using Fennec
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: simple fix to avoid crash
[String changes made/needed]: none

Comment 7

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8949471 [details]
Bug 1435499 - Guard against OOM when getting toolbar pixels;

Fix for a new crash from 59, let's take this for beta 10/11.

Comment 8

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/releases/mozilla-beta/rev/47310c2f2148

Comment 9

[Chris Peterson [:cpeterson]]

Moving toolbar bugs to the new GeckoView::Toolbar component.